You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/18 05:11:39 UTC

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #984: Update DataFusion to arrow 6.0 (WIP)

houqp commented on a change in pull request #984:
URL: https://github.com/apache/arrow-datafusion/pull/984#discussion_r711489468



##########
File path: datafusion/src/physical_plan/sort_preserving_merge.rs
##########
@@ -1156,10 +1156,24 @@ mod tests {
     #[tokio::test]
     async fn test_async() {
         let schema = test::aggr_test_schema();
-        let sort = vec![PhysicalSortExpr {
-            expr: col("c7", &schema).unwrap(),
-            options: SortOptions::default(),
-        }];
+        let sort = vec![

Review comment:
       @alamb FYI, @yjshen proposed a slightly cleaner fix for this failure by switching to column `c12`: https://github.com/houqp/arrow-datafusion/pull/4




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org