[GitHub] [helix] narendly commented on a change in pull request #1834: Add TF Available Threads Metrics

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #1834:
URL: https://github.com/apache/helix/pull/1834#discussion_r684798410



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/task/TaskSchedulingStage.java
##########
@@ -81,13 +81,16 @@ public void process(ClusterEvent event) throws Exception {
     // Reset current INIT/RUNNING tasks on participants for throttling
     cache.resetActiveTaskCount(currentStateOutput);
 
+    ClusterStatusMonitor clusterStatusMonitor =
+        event.getAttribute(AttributeName.clusterStatusMonitor.name());

Review comment:
       Should we just do a null check here and remove null checks in other places (e.g. JobMonitor)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org