You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metron.apache.org by justinleet <gi...@git.apache.org> on 2017/09/08 12:47:37 UTC

[GitHub] metron pull request #702: METRON-1114: Add group by capabilities to search R...

Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/702#discussion_r137763739
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/IndexConfig.java ---
    @@ -56,8 +52,10 @@ public IndexDao indexDao() {
           String hbaseProviderImpl = environment.getProperty(MetronRestConstants.INDEX_HBASE_TABLE_PROVIDER_IMPL, String.class, null);
           String indexDaoImpl = environment.getProperty(MetronRestConstants.INDEX_DAO_IMPL, String.class, null);
           int searchMaxResults = environment.getProperty(MetronRestConstants.SEARCH_MAX_RESULTS, Integer.class, -1);
    +      int searchMaxGroups = environment.getProperty(MetronRestConstants.SEARCH_MAX_GROUPS, Integer.class, 1000);
    --- End diff --
    
    Why do we say SEARCH_MAX_RESULTS grabs a default of -1, but SEARCH_MAX_GROUPS grabs a default of 1000?  I'd be inclined to make them consistent.


---