[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #6323: [INLONG-6322][Sort] Fix write data incorrect for doris connector with sink multiple scenario

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #6323:
URL: https://github.com/apache/inlong/pull/6323#discussion_r1008985506


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -258,35 +265,52 @@ public synchronized void close() throws IOException {
 
     @SuppressWarnings({"rawtypes"})
     public synchronized void flush() {
+        flushing = true;

Review Comment:
   The entire flush needs to ensure atomicity here.



##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -258,35 +265,52 @@ public synchronized void close() throws IOException {
 
     @SuppressWarnings({"rawtypes"})
     public synchronized void flush() {
+        flushing = true;
         if (batchMap.isEmpty()) {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org