You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/07/11 23:35:40 UTC

[GitHub] andreineculau commented on issue #3030: flawed logic in the new visualization timeout

andreineculau commented on issue #3030: flawed logic in the new visualization timeout
URL: https://github.com/apache/incubator-superset/issues/3030#issuecomment-314601177
 
 
   I don't know if you and @mistercrunch talked on other channels but the way that I read his issue https://github.com/apache/incubator-superset/issues/2734 is that he wants the 504 handled, not that the client should time out.
   
   The client cannot know why the timeout occurs, it could very well be that the proxy server has high CPU usage, or that there is high network latency on some end, etc etc etc anything but my data set being large. From that perspective, the message itself is even more confusing and hedging with "Perhaps" doesn't help one bit. Just to be clear, that timeout will occur also if the backend already sent 200 OK, and partial headers/body but didn't yet signal the end of the HTTP message. Heck, it can even be that the browser pool of connections is filled and that the request doesn't even get sent from the queue - see definition of jquery.ajax' timeout.
   
   But what is worse is that all of a sudden, superset instances become trapped by a magic 50s timeout. If indeed, @mistercrunch or someone else wanted/wants a client-side timeout instead of a world-wide known spinner that almost anyone knows it's either slow network or file too large or too much processing, then why not have it optional ? You show a friendly error message on all 504 errors, and optionally on a client-side timeout IFF the admin or maybe individual users in the future opt-in.
   
   FWIW 1. I have lived through these times https://productforums.google.com/forum/#!topic/chrome/gb_bZzmCnm4
   FWIW 2. the current http response timeout in browsers, or at least in Firefox is *5 minutes* - quite a difference from superset's *50 seconds*
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services