You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/08 16:55:10 UTC
[GitHub] [airflow] frankcash opened a new pull request #21427: eks_hook log level fatal -> FATAL
frankcash opened a new pull request #21427:
URL: https://github.com/apache/airflow/pull/21427
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: [#ISSUE](https://github.com/apache/airflow/issues/21421)
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
There is an issue with the value being set to override `AIRFLOW__LOGGING__LOGGING_LEVEL`. Where it requires an all capitalized value
```
airflow.exceptions.AirflowConfigException: `[logging] logging_level` should not be 'fatal'. Possible values: CRITICAL, FATAL, ERROR, WARN, WARNING, INFO, DEBUG.
```
closes: [#21421 ](https://github.com/apache/airflow/issues/21421)
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash edited a comment on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
frankcash edited a comment on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1033031805
@potiuk not sure why `Tests / Test docker-compose quick start (pull_request) ` failed the log is very verbose, not sure where the actual meat of it is. Please let me know / link me I have resolved the pytest config generation for the EKS Hook
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
frankcash commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1033001022
My bad, I will work on this. Thanks for the clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1032927203
Ah - there are some tests failures. Woudl you be able to test them quickly @frankcash so that I merge it for the RC2 release of providers tonight ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1033049631
Just docker-compose thingie ... merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
frankcash commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1033048072
All good @ferruzzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1032995439
https://github.com/apache/airflow/runs/5112996481?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
frankcash commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1033049835
Thanks @potiuk 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21427:
URL: https://github.com/apache/airflow/pull/21427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
frankcash commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1033031805
@potiuk not sure why `Tests / Test docker-compose quick start (pull_request) ` the log is very verbose, not sure where the actual meat of it is. Please let me know / link me I have resolved the pytest config generation for the EKS Hook
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1032995036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi edited a comment on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
ferruzzi edited a comment on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1033045476
If you update `hooks/test_eks.py` L1274 to `"FATAL"` it passes CI locally without any other changes.
[EDIT] Should have refreshed, my mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
frankcash commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1032989951
for the tests that failed is at as simple as running `./breeze tests --db-reset`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #21427: eks_hook log level fatal -> FATAL
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #21427:
URL: https://github.com/apache/airflow/pull/21427#issuecomment-1033045476
If you update `hooks/test_eks.py` L1274 to `"FATAL"` it passes CI locally without any other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org