You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/02 22:19:51 UTC
[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator
morhidi commented on code in PR #420:
URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1033671472
##########
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##########
@@ -79,7 +79,9 @@ spec:
{{- end }}
env:
- name: OPERATOR_NAMESPACE
Review Comment:
Sorry, I forgot to submit this comment, I'm trying to understand why we need to change this part from:
```
- name: OPERATOR_NAMESPACE
value: {{ .Release.Namespace }}
```
to
```
- name: OPERATOR_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
```
It doesn't seem to be related to the watch namespaces, otherwise the changes are good.
##########
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##########
@@ -79,7 +79,9 @@ spec:
{{- end }}
env:
- name: OPERATOR_NAMESPACE
Review Comment:
@jbusche @tagarr ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org