You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/31 23:18:31 UTC
[GitHub] [inlong] haibo-duan commented on a diff in pull request #5297: [INLONG-5296][Manager] Add fields for DataNode and InlongCluster
haibo-duan commented on code in PR #5297:
URL: https://github.com/apache/inlong/pull/5297#discussion_r934053170
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterServiceImpl.java:
##########
@@ -405,7 +405,7 @@ public Boolean bindTag(BindTagRequest request, String operator) {
InlongClusterEntity updateEntity = clusterMapper.selectById(id);
updateEntity.setClusterTags(updateTags);
updateEntity.setModifier(operator);
- int rowCount = clusterMapper.updateByIdSelective(updateEntity);
+ int rowCount = clusterMapper.updateById(updateEntity);
if (rowCount != InlongConstants.AFFECTED_ONE_ROW) {
Review Comment:
same as above
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterServiceImpl.java:
##########
@@ -215,7 +215,7 @@ public Boolean updateTag(ClusterTagRequest request, String operator) {
String updateTags = Joiner.on(",").join(tagSet);
entity.setClusterTags(updateTags);
entity.setModifier(operator);
- int rowCount = clusterMapper.updateByIdSelective(entity);
+ int rowCount = clusterMapper.updateById(entity);
if (rowCount != InlongConstants.AFFECTED_ONE_ROW) {
Review Comment:
Personally，local variable 'rowCount' is redundant.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterServiceImpl.java:
##########
@@ -793,7 +793,7 @@ private void removeClusterTag(InlongClusterEntity entity, String clusterTag, Str
String updateTags = Joiner.on(",").join(tagSet);
entity.setClusterTags(updateTags);
entity.setModifier(operator);
- int rowCount = clusterMapper.updateByIdSelective(entity);
+ int rowCount = clusterMapper.updateById(entity);
if (rowCount != InlongConstants.AFFECTED_ONE_ROW) {
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org