[jira] [Commented] (BEAM-1866) FnAPI support for Metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954063#comment-15954063 ] 

ASF GitHub Bot commented on BEAM-1866:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2412

    [BEAM-1866] DataflowRunner: disable PAssert use of metrics when FnAPI is enabled

    FnApi does not yet support metrics
    
    R: @tgroh 
    
    CC: @pabloem Pablo, I think the work you're doing to improve `PAssert` might be useful here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam fnapi-passert

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2412
    
----
commit 0a3a8b918ce66f11c610ce1948ce290e5f699520
Author: Dan Halperin <dh...@google.com>
Date:   2017-04-03T19:46:33Z

    DataflowRunner: disable PAssert use of metrics when FnAPI is enabled
    
    FnApi does not yet support metrics

----


> FnAPI support for Metrics
> -------------------------
>
>                 Key: BEAM-1866
>                 URL: https://issues.apache.org/jira/browse/BEAM-1866
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model-fn-api
>            Reporter: Daniel Halperin
>
> As part of the Fn API work, we need to define a Metrics interface between the Runner and the SDK. Right now, Metrics are simply lost.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)