You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/26 16:55:19 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #11264: KAFKA-13231; `TransactionalMessageCopier.start_node` should wait until the process if fully started

hachikuji commented on a change in pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#discussion_r696813850



##########
File path: tests/kafkatest/services/transactional_message_copier.py
##########
@@ -159,12 +159,16 @@ def pids(self, node):
     def alive(self, node):
         return len(self.pids(node)) > 0
 
+    def start_node(self, node):
+        BackgroundThreadService.start_node(self, node)
+        wait_until(lambda: self.alive(node), timeout_sec=60, err_msg="Message Copier failed to start")

Review comment:
       Is it worth adding `node` to these error messages?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org