You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Paul Nicolucci (JIRA)" <de...@myfaces.apache.org> on 2018/04/03 16:34:00 UTC
[jira] [Resolved] (MYFACES-4216) ViewHandler.getWebsocketURL should
be abstract / WEBSOCKET_PORT move
[ https://issues.apache.org/jira/browse/MYFACES-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Nicolucci resolved MYFACES-4216.
-------------------------------------
Resolution: Fixed
> ViewHandler.getWebsocketURL should be abstract / WEBSOCKET_PORT move
> --------------------------------------------------------------------
>
> Key: MYFACES-4216
> URL: https://issues.apache.org/jira/browse/MYFACES-4216
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-372
> Affects Versions: 2.3.0
> Reporter: Paul Nicolucci
> Assignee: Paul Nicolucci
> Priority: Minor
> Fix For: 2.3.1
>
> Attachments: MYFACES-4216.patch
>
>
> 1) Method should be abstract: [https://javaserverfaces.github.io/docs/2.3/javadocs/javax/faces/application/ViewHandler.html#getWebsocketURL-javax.faces.context.FacesContext-java.lang.String-]
>
> 2) public static final java.lang.String WEBSOCKET_PORT = "javax.faces.WEBSOCKET_PORT" -> This should not exist in the ViewHandler API according to the javadoc so moving it.
>
> I believe we'll need a dev-discussion here as it looks like the spec specifies the following:
> javax.faces.WEBSOCKET_ENDPOINT_PORT:
>
> In case your server is configured to run a WebSocket container on a different TCP port than the HTTP
> container, then you can use the optional javax.faces.WEBSOCKET_ENDPOINT_PORT integer context
> parameter in web.xml to explicitly specify the port.
> <context-param>
> <param-name>javax.faces.WEBSOCKET_ENDPOINT_PORT</param-name>
> <param-value>8000</param-value>
> </context-param>
>
> The following dev discussion outcome was to change the name of our parameter to match the spec: https://www.mail-archive.com/dev@myfaces.apache.org/msg68684.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)