[GitHub] [lucene-solr] dweiss commented on a change in pull request #1738: LUCENE-9454: upgrade hamcrest to version 2.2.

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #1738:
URL: https://github.com/apache/lucene-solr/pull/1738#discussion_r468451061



##########
File path: lucene/test-framework/build.gradle
##########
@@ -22,9 +22,13 @@ description = 'Framework for testing Lucene-based applications'
 dependencies {
   api project(':lucene:core')
 
-  api ("com.carrotsearch.randomizedtesting:randomizedtesting-runner")
-  api ('org.hamcrest:hamcrest-core')
-  api ("junit:junit")
+  api ("com.carrotsearch.randomizedtesting:randomizedtesting-runner", {

Review comment:
       Explanation: these exclusions are needed so that we don't pull in hamcrest-core which is a deprecated package just pointing at hamcrest.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org