[GitHub] [tvm] junrushao commented on a diff in pull request #15633: [Disco][Op] broadcast_from_zero

["junrushao (via GitHub)" <gi...@apache.org>]

junrushao commented on code in PR #15633:
URL: https://github.com/apache/tvm/pull/15633#discussion_r1307124823


##########
src/relax/op/ccl/ccl.h:
##########
@@ -35,6 +35,9 @@ namespace relax {
 /*! \brief AllReduce. */
 Expr allreduce(Expr data, String op_type);
 
+/*! \brief Broadcast data from worker-0 to all other workers. */
+Expr broadcast_from_zero(Expr data);

Review Comment:
   Let’s think of a consistent naming for this primitive across Relax and Disco/NCCL. broadcast_from_worker0 or broadcast_from_zero?



##########
src/relax/op/ccl/ccl.h:
##########
@@ -35,6 +35,9 @@ namespace relax {
 /*! \brief AllReduce. */
 Expr allreduce(Expr data, String op_type);
 
+/*! \brief Broadcast data from worker-0 to all other workers. */
+Expr broadcast_from_zero(Expr data);

Review Comment:
   Let’s think of a consistent naming for this primitive across Relax and Disco/NCCL. broadcast_from_worker0 or broadcast_from_zero?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org