[PATCH] Re: Proposal for ObjectKey return value on BaseObjects save()

[Jason Grant <ja...@logular.com>]

Thanks Jon,

patchfile.txt included.

I must say it's good to be a contributor at last - hoping to help out in
more small ways...

J.



On 2001.04.20 21:04:25 -0400 Jon Stevens wrote:
> on 4/21/01 7:58 AM, "Jason Grant" <ja...@logular.com> wrote:
> 
> > I'm not sure what tool is used to convert XML->HTML, so
> > the rendered appearance is untested (i.e. I'm not sure how the embedded
> XML
> > turns out).
> 
> <http://jakarta.apache.org/site/jakarta-site2.html>
> <http://jakarta.apache.org/velocity/anakia.html>
> 
> All you need to do is this:
> 
> cvs co jakarta-site2
> cvs co jakarta-turbine
> cd jakarta-turbine/build
> ./build-turbine.sh docs
> 
> >  I'm happy to test/fix tho.  Also, is this sort of diff
> > acceptable (output from diff -C)?
> 
> Close. Your email application wrapped the lines badly so it might be a
> good
> idea to put the patch file on a website for someone to download or
> enclose
> it as an enclosure in your email instead of inline...
> 
> Instead of this:
> [xdocs] $ diff -C 5 peers.xml peers.xml.orig
> 
> It should be this:
> [xdocs] $ diff -u peers.xml.orig peers.xml >> patchfile.txt
> 
> You should also prefix your Subject: with [PATCH]
> 
> This is also documented at:
> 
> <http://jakarta.apache.org/site/source.html>
> 
> thanks,
> 
> -jon
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-user-help@jakarta.apache.org
> 
> 

Re: [PATCH] Re: Proposal for ObjectKey return value on BaseObjects save()

[Jon Stevens <jo...@latchkey.com>]

Thanks jason!

You code is now in CVS and shows up on the website...

on 4/21/01 8:43 AM, "Jason Grant" <ja...@logular.com> wrote:

> Thanks Jon,
> 
> patchfile.txt included.

The only other suggestion is to line wrap the .xml file at 78 columns.

> I must say it's good to be a contributor at last - hoping to help out in
> more small ways...

Well, once we get a feeling that you know what you are up to, we can give
you commit access so that you can commit things yourself. :-) It has been a
while since we have added a new contributor to Turbine...it would be nice to
get some fresh blood in here...

thanks,

-jon


---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-user-help@jakarta.apache.org