You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Baoyuantop (via GitHub)" <gi...@apache.org> on 2023/05/19 06:22:38 UTC
[GitHub] [apisix-dashboard] Baoyuantop opened a new pull request, #2809: fix: edit comsumer without plugin
Baoyuantop opened a new pull request, #2809:
URL: https://github.com/apache/apisix-dashboard/pull/2809
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Refer to a slack user report https://the-asf.slack.com/archives/CUC5MN17A/p1684470370003649
**Related issues**
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop merged pull request #2809: fix: edit comsumer without plugin
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop merged PR #2809:
URL: https://github.com/apache/apisix-dashboard/pull/2809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2809: fix: edit comsumer without plugin
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2809:
URL: https://github.com/apache/apisix-dashboard/pull/2809#issuecomment-1554076993
## [Codecov](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2809](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5063b61) into [master](https://app.codecov.io/gh/apache/apisix-dashboard/commit/8390d3dfd53bae19fc31e5dbc8753882e69a8ff3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8390d3d) will **increase** coverage by `0.23%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 5063b61 differs from pull request most recent head 4330459. Consider uploading reports for the commit 4330459 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2809 +/- ##
==========================================
+ Coverage 68.61% 68.84% +0.23%
==========================================
Files 139 39 -100
Lines 3769 1040 -2729
Branches 883 269 -614
==========================================
- Hits 2586 716 -1870
+ Misses 1183 324 -859
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `68.84% <100.00%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [web/src/pages/Consumer/Create.tsx](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `92.50% <100.00%> (+15.00%)` | :arrow_up: |
... and [114 files with indirect coverage changes](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2809/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org