[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #2171: minor: Avoid per cell evaluation in Coalesce, use zip in CaseWhen

[GitBox <gi...@apache.org>]

Dandandan commented on code in PR #2171:
URL: https://github.com/apache/arrow-datafusion/pull/2171#discussion_r845175860


##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -19,7 +19,8 @@ use std::{any::Any, sync::Arc};
 
 use crate::expressions::try_cast;
 use crate::PhysicalExpr;
-use arrow::array::{self, *};
+use arrow::array::*;
+use arrow::compute::kernels::zip::zip;

Review Comment:
   I also didn't know this one.
   
   Zip seems a confusing name for this functionality?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org