You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/28 14:37:36 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue #10537: Use RuleConfigurationFixture instead of ShardingRuleConfiguration for test case in governance module

terrymanu opened a new issue #10537:
URL: https://github.com/apache/shardingsphere/issues/10537


   For decouple features and governance module, it is better to use  RuleConfigurationFixture instead of ShardingRuleConfiguration for test cases. They are:
   
   - [ ] RuleChangedListenerTest.assertCreateEventWithRule()
   - [ ] SchemaRuleRegistryServiceTest.assertLoadWithExistedNode()


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on issue #10537: Use RuleConfigurationFixture instead of ShardingRuleConfiguration for test case in governance module

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #10537:
URL: https://github.com/apache/shardingsphere/issues/10537#issuecomment-852671258


   > hi can i try to do this ?
   
   assigned


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu closed issue #10537: Use RuleConfigurationFixture instead of ShardingRuleConfiguration for test case in governance module

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #10537:
URL: https://github.com/apache/shardingsphere/issues/10537


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] totalo commented on issue #10537: Use RuleConfigurationFixture instead of ShardingRuleConfiguration for test case in governance module

Posted by GitBox <gi...@apache.org>.
totalo commented on issue #10537:
URL: https://github.com/apache/shardingsphere/issues/10537#issuecomment-851201113


   hi can i try to do this ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org