You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/05 19:29:01 UTC
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5613
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Global search/replace: audience="Cloudera" -> audience="hidden".
For this change to land in master, the audience="hidden" code review
needs to be completed first. Otherwise, the doc build would still work
but the audience="hidden" content would be visible rather than hidden as
desired.
Some work happening in parallel might introduce additional instances of
audience="Cloudera". I suggest addressing those in a followup CR so this
global change can land quickly.
Since the changes apply across so many different files, but are so
narrow in scope, I suggest that the way to validate (check that no
extraneous changes were introduced accidentally) is to diff just the
changed lines:
git diff -U0 HEAD^ HEAD
Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
---
M docs/impala.ditamap
M docs/topics/impala_abort_on_error.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_alter_function.xml
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_appx_count_distinct.xml
M docs/topics/impala_appx_median.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_avg.xml
M docs/topics/impala_avro.xml
M docs/topics/impala_batch_size.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_char.xml
M docs/topics/impala_cluster_sizing.xml
M docs/topics/impala_comments.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_compression_codec.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_concepts.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_count.xml
M docs/topics/impala_create_data_source.xml
M docs/topics/impala_create_database.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_create_role.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_create_view.xml
M docs/topics/impala_datatypes.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_debug_action.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_delete.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_development.xml
M docs/topics/impala_disable_cached_reads.xml
M docs/topics/impala_disable_codegen.xml
M docs/topics/impala_disable_outermost_topn.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_disable_streaming_preaggregations.xml
M docs/topics/impala_disable_unsafe_spills.xml
M docs/topics/impala_distinct.xml
M docs/topics/impala_drop_data_source.xml
M docs/topics/impala_drop_database.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_drop_role.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_drop_table.xml
M docs/topics/impala_drop_view.xml
M docs/topics/impala_exec_single_node_rows_threshold.xml
M docs/topics/impala_explain.xml
M docs/topics/impala_explain_level.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_file_formats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_group_concat.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_hbase_cache_blocks.xml
M docs/topics/impala_hbase_caching.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_install.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_joins.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_lineage.xml
M docs/topics/impala_literals.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_live_summary.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_math_functions.xml
M docs/topics/impala_max.xml
M docs/topics/impala_max_block_mgr_memory.xml
M docs/topics/impala_max_errors.xml
M docs/topics/impala_max_num_runtime_filters.xml
M docs/topics/impala_max_scan_range_length.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_min.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_ndv.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_num_nodes.xml
M docs/topics/impala_num_scanner_threads.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_operators.xml
M docs/topics/impala_optimize_partition_key_scans.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_parquet_annotate_strings_utf8.xml
M docs/topics/impala_parquet_compression_codec.xml
M docs/topics/impala_parquet_fallback_schema_resolution.xml
M docs/topics/impala_parquet_file_size.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_performance.xml
M docs/topics/impala_planning.xml
M docs/topics/impala_porting.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prefetch_mode.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_query_timeout_s.xml
M docs/topics/impala_rcfile.xml
M docs/topics/impala_refresh.xml
M docs/topics/impala_replica_preference.xml
M docs/topics/impala_request_pool.xml
M docs/topics/impala_reservation_request_timeout.xml
M docs/topics/impala_reserved_words.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_rm_initial_mem.xml
M docs/topics/impala_runtime_bloom_filter_size.xml
M docs/topics/impala_runtime_filter_max_size.xml
M docs/topics/impala_runtime_filter_min_size.xml
M docs/topics/impala_runtime_filter_mode.xml
M docs/topics/impala_runtime_filter_wait_time_ms.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_s3_skip_insert_staging.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_scan_node_codegen_threshold.xml
M docs/topics/impala_schedule_random_replica.xml
M docs/topics/impala_schema_objects.xml
M docs/topics/impala_select.xml
M docs/topics/impala_seq_compression_mode.xml
M docs/topics/impala_seqfile.xml
M docs/topics/impala_set.xml
M docs/topics/impala_shell_commands.xml
M docs/topics/impala_show.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_stddev.xml
M docs/topics/impala_string_functions.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_sum.xml
M docs/topics/impala_support_start_over.xml
M docs/topics/impala_sync_ddl.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_trouble_bad_results.xml
M docs/topics/impala_trouble_memory.xml
M docs/topics/impala_trouble_query_fail.xml
M docs/topics/impala_trouble_sql.xml
M docs/topics/impala_trouble_startup.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_truncate_table.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_update.xml
M docs/topics/impala_upsert.xml
M docs/topics/impala_use.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
M docs/topics/impala_variance.xml
M docs/topics/impala_webui.xml
M docs/topics/impala_window_functions.xml
169 files changed, 602 insertions(+), 602 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/5613/1
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Patch Set 2: Code-Review+1
pulled into private branch, resolved merge conflicts, and build PDF. Checked the section, "Scalability Considerations for Impala" to make sure none of the sections that are supposed to be <audience = hidden> are not displaying in the build ("Overview and Guidelines for Impala Memory Usage," "Scalability Considerations for Impala Cluster Size and Topology," and "Scaling the Number of Concurrent Connections"). They do not display as expected.
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/19/
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Patch Set 2: Code-Review+1 Verified+1
I've resolved the conflict with another CR and verified that the info intended to be hidden is still hidden after this change.
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Global search/replace: audience="Cloudera" -> audience="hidden".
For this change to land in master, the audience="hidden" code review
needs to be completed first. Otherwise, the doc build would still work
but the audience="hidden" content would be visible rather than hidden as
desired.
Some work happening in parallel might introduce additional instances of
audience="Cloudera". I suggest addressing those in a followup CR so this
global change can land quickly.
Since the changes apply across so many different files, but are so
narrow in scope, I suggest that the way to validate (check that no
extraneous changes were introduced accidentally) is to diff just the
changed lines:
git diff -U0 HEAD^ HEAD
In patch set 2, I updated other topics marked audience="Cloudera"
by CRs that were pushed in the meantime.
Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Reviewed-on: http://gerrit.cloudera.org:8080/5613
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_abort_on_error.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_alter_function.xml
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_appx_count_distinct.xml
M docs/topics/impala_appx_median.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_avg.xml
M docs/topics/impala_avro.xml
M docs/topics/impala_batch_size.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_char.xml
M docs/topics/impala_cluster_sizing.xml
M docs/topics/impala_cm_installation.xml
M docs/topics/impala_comments.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_compression_codec.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_concepts.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_count.xml
M docs/topics/impala_create_data_source.xml
M docs/topics/impala_create_database.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_create_role.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_create_view.xml
M docs/topics/impala_datatypes.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_debug_action.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_delete.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_development.xml
M docs/topics/impala_disable_cached_reads.xml
M docs/topics/impala_disable_codegen.xml
M docs/topics/impala_disable_outermost_topn.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_disable_streaming_preaggregations.xml
M docs/topics/impala_disable_unsafe_spills.xml
M docs/topics/impala_distinct.xml
M docs/topics/impala_drop_data_source.xml
M docs/topics/impala_drop_database.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_drop_role.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_drop_table.xml
M docs/topics/impala_drop_view.xml
M docs/topics/impala_exec_single_node_rows_threshold.xml
M docs/topics/impala_explain.xml
M docs/topics/impala_explain_level.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_file_formats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_group_concat.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_hbase_cache_blocks.xml
M docs/topics/impala_hbase_caching.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_install.xml
M docs/topics/impala_intro.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_joins.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_lineage.xml
M docs/topics/impala_literals.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_live_summary.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_math_functions.xml
M docs/topics/impala_max.xml
M docs/topics/impala_max_block_mgr_memory.xml
M docs/topics/impala_max_errors.xml
M docs/topics/impala_max_num_runtime_filters.xml
M docs/topics/impala_max_scan_range_length.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_min.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_ndv.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_num_nodes.xml
M docs/topics/impala_num_scanner_threads.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_operators.xml
M docs/topics/impala_optimize_partition_key_scans.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_parquet_annotate_strings_utf8.xml
M docs/topics/impala_parquet_compression_codec.xml
M docs/topics/impala_parquet_fallback_schema_resolution.xml
M docs/topics/impala_parquet_file_size.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_performance.xml
M docs/topics/impala_planning.xml
M docs/topics/impala_porting.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prefetch_mode.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_query_timeout_s.xml
M docs/topics/impala_rcfile.xml
M docs/topics/impala_refresh.xml
M docs/topics/impala_replica_preference.xml
M docs/topics/impala_request_pool.xml
M docs/topics/impala_reservation_request_timeout.xml
M docs/topics/impala_reserved_words.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_rm_initial_mem.xml
M docs/topics/impala_runtime_bloom_filter_size.xml
M docs/topics/impala_runtime_filter_max_size.xml
M docs/topics/impala_runtime_filter_min_size.xml
M docs/topics/impala_runtime_filter_mode.xml
M docs/topics/impala_runtime_filter_wait_time_ms.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_s3_skip_insert_staging.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_scan_node_codegen_threshold.xml
M docs/topics/impala_schedule_random_replica.xml
M docs/topics/impala_schema_objects.xml
M docs/topics/impala_select.xml
M docs/topics/impala_seq_compression_mode.xml
M docs/topics/impala_seqfile.xml
M docs/topics/impala_set.xml
M docs/topics/impala_shell_commands.xml
M docs/topics/impala_show.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_stddev.xml
M docs/topics/impala_string_functions.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_sum.xml
M docs/topics/impala_support_start_over.xml
M docs/topics/impala_sync_ddl.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_trouble_bad_results.xml
M docs/topics/impala_trouble_memory.xml
M docs/topics/impala_trouble_query_fail.xml
M docs/topics/impala_trouble_sql.xml
M docs/topics/impala_trouble_startup.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_truncate_table.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_update.xml
M docs/topics/impala_upgrading.xml
M docs/topics/impala_upsert.xml
M docs/topics/impala_use.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
M docs/topics/impala_variance.xml
M docs/topics/impala_webui.xml
M docs/topics/impala_window_functions.xml
176 files changed, 642 insertions(+), 642 deletions(-)
Approvals:
Impala Public Jenkins: Verified
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Patch Set 3: Code-Review+2
Resolved another merge conflict, tidied up a couple more instances of audience="Cloudera" that were added in the meantime.
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Laurel Hale,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5613
to look at the new patch set (#3).
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Global search/replace: audience="Cloudera" -> audience="hidden".
For this change to land in master, the audience="hidden" code review
needs to be completed first. Otherwise, the doc build would still work
but the audience="hidden" content would be visible rather than hidden as
desired.
Some work happening in parallel might introduce additional instances of
audience="Cloudera". I suggest addressing those in a followup CR so this
global change can land quickly.
Since the changes apply across so many different files, but are so
narrow in scope, I suggest that the way to validate (check that no
extraneous changes were introduced accidentally) is to diff just the
changed lines:
git diff -U0 HEAD^ HEAD
In patch set 2, I updated other topics marked audience="Cloudera"
by CRs that were pushed in the meantime.
Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_abort_on_error.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_alter_function.xml
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_appx_count_distinct.xml
M docs/topics/impala_appx_median.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_avg.xml
M docs/topics/impala_avro.xml
M docs/topics/impala_batch_size.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_char.xml
M docs/topics/impala_cluster_sizing.xml
M docs/topics/impala_cm_installation.xml
M docs/topics/impala_comments.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_compression_codec.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_concepts.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_count.xml
M docs/topics/impala_create_data_source.xml
M docs/topics/impala_create_database.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_create_role.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_create_view.xml
M docs/topics/impala_datatypes.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_debug_action.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_delete.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_development.xml
M docs/topics/impala_disable_cached_reads.xml
M docs/topics/impala_disable_codegen.xml
M docs/topics/impala_disable_outermost_topn.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_disable_streaming_preaggregations.xml
M docs/topics/impala_disable_unsafe_spills.xml
M docs/topics/impala_distinct.xml
M docs/topics/impala_drop_data_source.xml
M docs/topics/impala_drop_database.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_drop_role.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_drop_table.xml
M docs/topics/impala_drop_view.xml
M docs/topics/impala_exec_single_node_rows_threshold.xml
M docs/topics/impala_explain.xml
M docs/topics/impala_explain_level.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_file_formats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_group_concat.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_hbase_cache_blocks.xml
M docs/topics/impala_hbase_caching.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_install.xml
M docs/topics/impala_intro.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_joins.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_lineage.xml
M docs/topics/impala_literals.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_live_summary.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_math_functions.xml
M docs/topics/impala_max.xml
M docs/topics/impala_max_block_mgr_memory.xml
M docs/topics/impala_max_errors.xml
M docs/topics/impala_max_num_runtime_filters.xml
M docs/topics/impala_max_scan_range_length.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_min.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_ndv.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_num_nodes.xml
M docs/topics/impala_num_scanner_threads.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_operators.xml
M docs/topics/impala_optimize_partition_key_scans.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_parquet_annotate_strings_utf8.xml
M docs/topics/impala_parquet_compression_codec.xml
M docs/topics/impala_parquet_fallback_schema_resolution.xml
M docs/topics/impala_parquet_file_size.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_performance.xml
M docs/topics/impala_planning.xml
M docs/topics/impala_porting.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prefetch_mode.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_query_timeout_s.xml
M docs/topics/impala_rcfile.xml
M docs/topics/impala_refresh.xml
M docs/topics/impala_replica_preference.xml
M docs/topics/impala_request_pool.xml
M docs/topics/impala_reservation_request_timeout.xml
M docs/topics/impala_reserved_words.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_rm_initial_mem.xml
M docs/topics/impala_runtime_bloom_filter_size.xml
M docs/topics/impala_runtime_filter_max_size.xml
M docs/topics/impala_runtime_filter_min_size.xml
M docs/topics/impala_runtime_filter_mode.xml
M docs/topics/impala_runtime_filter_wait_time_ms.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_s3_skip_insert_staging.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_scan_node_codegen_threshold.xml
M docs/topics/impala_schedule_random_replica.xml
M docs/topics/impala_schema_objects.xml
M docs/topics/impala_select.xml
M docs/topics/impala_seq_compression_mode.xml
M docs/topics/impala_seqfile.xml
M docs/topics/impala_set.xml
M docs/topics/impala_shell_commands.xml
M docs/topics/impala_show.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_stddev.xml
M docs/topics/impala_string_functions.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_sum.xml
M docs/topics/impala_support_start_over.xml
M docs/topics/impala_sync_ddl.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_trouble_bad_results.xml
M docs/topics/impala_trouble_memory.xml
M docs/topics/impala_trouble_query_fail.xml
M docs/topics/impala_trouble_sql.xml
M docs/topics/impala_trouble_startup.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_truncate_table.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_update.xml
M docs/topics/impala_upgrading.xml
M docs/topics/impala_upsert.xml
M docs/topics/impala_use.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
M docs/topics/impala_variance.xml
M docs/topics/impala_webui.xml
M docs/topics/impala_window_functions.xml
176 files changed, 642 insertions(+), 642 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/5613/3
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: Global search/replace: audience="Cloudera" -> audience="hidden".
......................................................................
Global search/replace: audience="Cloudera" -> audience="hidden".
For this change to land in master, the audience="hidden" code review
needs to be completed first. Otherwise, the doc build would still work
but the audience="hidden" content would be visible rather than hidden as
desired.
Some work happening in parallel might introduce additional instances of
audience="Cloudera". I suggest addressing those in a followup CR so this
global change can land quickly.
Since the changes apply across so many different files, but are so
narrow in scope, I suggest that the way to validate (check that no
extraneous changes were introduced accidentally) is to diff just the
changed lines:
git diff -U0 HEAD^ HEAD
In patch set 2, I updated other topics marked audience="Cloudera"
by CRs that were pushed in the meantime.
Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
---
M docs/impala.ditamap
M docs/topics/impala_abort_on_error.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_alter_function.xml
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_appx_count_distinct.xml
M docs/topics/impala_appx_median.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_avg.xml
M docs/topics/impala_avro.xml
M docs/topics/impala_batch_size.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_char.xml
M docs/topics/impala_cluster_sizing.xml
M docs/topics/impala_cm_installation.xml
M docs/topics/impala_comments.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_compression_codec.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_concepts.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_count.xml
M docs/topics/impala_create_data_source.xml
M docs/topics/impala_create_database.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_create_role.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_create_view.xml
M docs/topics/impala_datatypes.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_debug_action.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_delete.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_development.xml
M docs/topics/impala_disable_cached_reads.xml
M docs/topics/impala_disable_codegen.xml
M docs/topics/impala_disable_outermost_topn.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_disable_streaming_preaggregations.xml
M docs/topics/impala_disable_unsafe_spills.xml
M docs/topics/impala_distinct.xml
M docs/topics/impala_drop_data_source.xml
M docs/topics/impala_drop_database.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_drop_role.xml
M docs/topics/impala_drop_stats.xml
M docs/topics/impala_drop_table.xml
M docs/topics/impala_drop_view.xml
M docs/topics/impala_exec_single_node_rows_threshold.xml
M docs/topics/impala_explain.xml
M docs/topics/impala_explain_level.xml
M docs/topics/impala_faq.xml
M docs/topics/impala_file_formats.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_group_concat.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_hbase_cache_blocks.xml
M docs/topics/impala_hbase_caching.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_impala_shell.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_install.xml
M docs/topics/impala_intro.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_joins.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_lineage.xml
M docs/topics/impala_literals.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_live_summary.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_math_functions.xml
M docs/topics/impala_max.xml
M docs/topics/impala_max_block_mgr_memory.xml
M docs/topics/impala_max_errors.xml
M docs/topics/impala_max_num_runtime_filters.xml
M docs/topics/impala_max_scan_range_length.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_min.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_ndv.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_num_nodes.xml
M docs/topics/impala_num_scanner_threads.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_operators.xml
M docs/topics/impala_optimize_partition_key_scans.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_parquet_annotate_strings_utf8.xml
M docs/topics/impala_parquet_compression_codec.xml
M docs/topics/impala_parquet_fallback_schema_resolution.xml
M docs/topics/impala_parquet_file_size.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_performance.xml
M docs/topics/impala_planning.xml
M docs/topics/impala_porting.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prefetch_mode.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_query_timeout_s.xml
M docs/topics/impala_rcfile.xml
M docs/topics/impala_refresh.xml
M docs/topics/impala_replica_preference.xml
M docs/topics/impala_request_pool.xml
M docs/topics/impala_reservation_request_timeout.xml
M docs/topics/impala_reserved_words.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_rm_initial_mem.xml
M docs/topics/impala_runtime_bloom_filter_size.xml
M docs/topics/impala_runtime_filter_max_size.xml
M docs/topics/impala_runtime_filter_min_size.xml
M docs/topics/impala_runtime_filter_mode.xml
M docs/topics/impala_runtime_filter_wait_time_ms.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_s3_skip_insert_staging.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_scan_node_codegen_threshold.xml
M docs/topics/impala_schedule_random_replica.xml
M docs/topics/impala_schema_objects.xml
M docs/topics/impala_select.xml
M docs/topics/impala_seq_compression_mode.xml
M docs/topics/impala_seqfile.xml
M docs/topics/impala_set.xml
M docs/topics/impala_shell_commands.xml
M docs/topics/impala_show.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_stddev.xml
M docs/topics/impala_string_functions.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_sum.xml
M docs/topics/impala_support_start_over.xml
M docs/topics/impala_sync_ddl.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_trouble_bad_results.xml
M docs/topics/impala_trouble_memory.xml
M docs/topics/impala_trouble_query_fail.xml
M docs/topics/impala_trouble_sql.xml
M docs/topics/impala_trouble_startup.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_truncate_table.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_update.xml
M docs/topics/impala_upgrading.xml
M docs/topics/impala_upsert.xml
M docs/topics/impala_use.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
M docs/topics/impala_variance.xml
M docs/topics/impala_webui.xml
M docs/topics/impala_window_functions.xml
175 files changed, 640 insertions(+), 640 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/5613/2
--
To view, visit http://gerrit.cloudera.org:8080/5613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic93d89da77e1f51bbf548a522d98d0c4e2fb31c8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>