[GitHub] mistercrunch commented on a change in pull request #5858: Xtine/mapbox pan on filter

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5858: Xtine/mapbox pan on filter
URL: https://github.com/apache/incubator-superset/pull/5858#discussion_r216738211
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -2015,6 +2015,9 @@ def get_data(self, df):
             ],
         }
 
+        southWest = [df[fd.get('all_columns_x')].min(), df[fd.get('all_columns_y')].min()]
 
 Review comment:
   NIT (optional): you could save some hash lookups by going `x_series = df[fd.get('all_columns_x')]` first

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org