[GitHub] [doris] dataroaring commented on a diff in pull request #10921: [feature-wip](unique-key-merge-on-write) Add agg cache for delete bitmap DSIP-018

[GitBox <gi...@apache.org>]

dataroaring commented on code in PR #10921:
URL: https://github.com/apache/doris/pull/10921#discussion_r923421933


##########
be/src/olap/tablet_meta.h:
##########
@@ -353,6 +353,69 @@ class DeleteBitmap {
      * @param other
      */
     void merge(const DeleteBitmap& other);
+
+    /**
+     * Checks if the given row is marked deleted in bitmap with the condition:
+     * all the bitmaps that
+     * RowsetId and SegmentId are the same as the given ones,
+     * and Version <= the given Version
+     *
+     * Note: aggregation cache may be used.
+     *
+     * @return true if marked deleted
+     */
+    bool contains_agg(const BitmapKey& bitmap, uint32_t row_id) const;
+
+    /**
+     * Gets aggregated delete_bitmap on rowset_id and version, the same effect:
+     * `select sum(roarging::Roaring) where RowsetId=rowset_id and SegmentId=seg_id and Version <= version`

Review Comment:
   typo
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org