[jira] [Commented] (YARN-728) Yarn and MR default classpath are wrong on Windows

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668801#comment-13668801 ] 

Hadoop QA commented on YARN-728:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12585106/YARN-728.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1016//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1016//console

This message is automatically generated.
                
> Yarn and MR default classpath are wrong on Windows
> --------------------------------------------------
>
>                 Key: YARN-728
>                 URL: https://issues.apache.org/jira/browse/YARN-728
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>         Environment: Windows
>            Reporter: Mostafa Elhemali
>         Attachments: YARN-728.patch
>
>
> On Windows, the environment variables need to be used as %X% not $X as in Linux/Unix. This is handled in code in Yarn in the ApplicationConstants$Environment.$() method. However there are two problems in Windows today where this doesn't work:
> # In yarn-default.xml and mapred-default.xml, the yarn.application.classpath and mapreduce.application.classpath are defined with hard-coded values that use the Linux form (e.g. $HADOOP_CONF_HOME).
> # In MRJobConfig, the DEFAULT_MAPREDUCE_APPLICATION_CLASSPATH constant is defined using the Linux form for HADOOP_MAPRED_HOME: $HADOOP_MAPRED_HOME.
> This causes MR applications to fail on Windows because it can't find the MRAppMaster class because the classpath is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira