[GitHub] [accumulo] ctubbsii commented on pull request #2492: Add goal message to Fate. Closes #1249

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #2492:
URL: https://github.com/apache/accumulo/pull/2492#issuecomment-1039303196


   @milleruntime I think GitHub is supposed to auto-link PRs to their referenced issues. However, I don't think it works the way you're doing it. It should work when you add the [closing keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) to the description or body of a commit message, but it does not seem to work when you add it to the subject line. For consistency (and for less confusion), it's probably best to put these in the body of the commit anyway, so that way when GitHub appends the PR number on merge, it looks a bit nicer:
   
   ```
   Add goal message to Fate (#2492)
   ```
   
   vs. 
   
   ```
   Add goal message to Fate. Closes #1249 (#2492)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org