[GitHub] [spark] srowen commented on a change in pull request #33263: [SPARK-35027][CORE] Close the inputStream in FileAppender when writin…

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #33263:
URL: https://github.com/apache/spark/pull/33263#discussion_r667134341



##########
File path: core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala
##########
@@ -113,7 +123,18 @@ private[spark] class FileAppender(inputStream: InputStream, file: File, bufferSi
 private[spark] object FileAppender extends Logging {
 
   /** Create the right appender based on Spark configuration */
-  def apply(inputStream: InputStream, file: File, conf: SparkConf): FileAppender = {

Review comment:
       I suppose you could introduce a new optional argument at the end rather than overload. If it raises a MiMa error we can exclude it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org