You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2015/12/21 08:29:04 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1264
CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing
Reproducible Steps:
================
1.Create a customer gateway for a VPC.
2.Edit it using UI(API call is UpdateVpnCustomerGateway).
3.When we try to update the customer vpn gateway with connection state is not in "Error", we see the API error but that won't be reflected to the user in UI.
Actual Behaviour:
==============
The API throws error. But UI doesn't show it to user.
Expected Behaviour:
=================
The UI should show the error to user.
Fix:
===
TypeError: json.updatecustomergatewayresponse is undefined
The response name was wrong so corrected it.
It should be json.updatevpncustomergatewayresponse.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin10
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1264.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1264
----
commit 3022dd3094d45d6574c4d68d3a0b4e6ffde6ad11
Author: Nitin Kumar Maharana <ni...@gmail.com>
Date: 2015-12-21T07:37:33Z
CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing
The response name was wrong so corrected it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168282637
Sure @remibergsma. I will a PR against 4.7. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168115603
cc @kishankavala @bhaisaab @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-166223301
@nitin-maharana
I am not sure if it is necessary to add the following change after success, but I added it in my fix, basides your change.
```
error: function(json) {
args.response.error(parseXMLHttpResponse(json));
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-166258585
Hi @ustcweizhou, The error function is not necessary but it is good to write this in call. Here the request doesn't fail but throws an error. Thanks for the comment, I will update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168289642
Closing this PR as made a new PR #1300 (Against 4.7 which will be merged in master later).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168244857
@nitin-maharana Thanks for the fix! I'd suggest making this PR against 4.7 (it will end up on master as well).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-168148620
LGTM.
This is same to the fix in our internal branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1264#issuecomment-166223258
cc @JayapalUradi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---