[GitHub] [spark] tgravescs commented on pull request #37268: [SPARK-39853][CORE] Support stage level task resource schedule for standalone cluster when dynamic allocation disabled

[GitBox <gi...@apache.org>]

tgravescs commented on PR #37268:
URL: https://github.com/apache/spark/pull/37268#issuecomment-1201375712

   so I would like to see the issue or this PR description have much more details about design, API, and its behavior.
   For instance:
   
   ```
   Does this PR introduce any user-facing change?
   
   No 
   ```
   
   This is not true, this is very much user impacting API. 
   
   Also the issue I linked to talked about the policy for reusing executors. What is the proposal for that here?
   What happens if the task resource specified doesn't fit in the executor resources?
   I'd like to make sure we come to agreement on what this api is and does and user impact of that. 
   Does this api also apply to reusing executor with dynamic allocation on... as commented above seems limiting.
   This is a public API so I want to make sure the changes work in various situations.
   
   Docs will need to update to explain new API and behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org