You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by deil87 <gi...@git.apache.org> on 2018/02/26 14:41:32 UTC
[GitHub] spark pull request #20677: Event time can't be greater then processing time....
GitHub user deil87 opened a pull request:
https://github.com/apache/spark/pull/20677
Event time can't be greater then processing time. 12:21, owl. Mistake…
… on image.
## What changes were proposed in this pull request?
There is an error on image. Point 12:21 for owl can't have 12:19 processing time. Consequently new watermark should be computed on another data (12:15, cat). Donkey still will be rejected I suppose but I'm not sure whether those watermarks inclusive or exclusive. If watermark is set to 12:05 then I guess intermediate state for window 11:55(inclusive)-12:05(exclusive) could be cleared and there is no place for Donkey anymore. You need to change image and depending on how you will change it you need to adjust the text.
## How was this patch tested?
No tests for docs.
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/deil87/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20677.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20677
----
commit 1bf1017db1e484d0ad85c14b166961ba35b08cc8
Author: Spiridonov Andrey <de...@...>
Date: 2018-02-26T14:30:45Z
Event time can't be greater then processing time. 12:21, owl. Mistake on image.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20677
@deil87 if you're willing to just edit the PNG as best you can you can proceed that way. I don't think @tdas is active anymore
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20677
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by deil87 <gi...@git.apache.org>.
Github user deil87 commented on the issue:
https://github.com/apache/spark/pull/20677
This patch needs to be changed before it can be merged. It is an image that involved in mistake and I don't have sources for image to change it nicely. Admins should verify and suggest next actions.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20677
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20677
I agree. The (12:14, dog) event at 12:12 also happens "early". I suppose it could have been intentional, if the idea is to illustrate disagreement about time between the event producer and stream processor, but I'm not sure. At the least, it is an unnecessary twist, and suspect the example would be better without it.
@tdas do you have the source for the image?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by deil87 <gi...@git.apache.org>.
Github user deil87 commented on the issue:
https://github.com/apache/spark/pull/20677
Will anyone take a look at this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20677
I will have to spend some time to look into the issue. I can do it later next week. If there is a mistake, I apologize for it!! And I will fix it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by deil87 <gi...@git.apache.org>.
Github user deil87 commented on the issue:
https://github.com/apache/spark/pull/20677
When we are reading documentation not for example learning on the courses we do not expect such intentional mistakes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20677: Event time can't be greater then processing time. 12:21,...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20677
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org