[GitHub] [lucene-solr] mikemccand commented on a change in pull request #700: LUCENE-8835: Respect file extension when listing files form FileSwitchDirectory

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #700: LUCENE-8835: Respect file extension when listing files form FileSwitchDirectory
URL: https://github.com/apache/lucene-solr/pull/700#discussion_r292498430
 
 

 ##########
 File path: lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java
 ##########
 @@ -1414,6 +1415,9 @@ private static BaseDirectoryWrapper newFSDirectory(Path f, LockFactory lf, boole
       }
 
       Directory fsdir = newFSDirectoryImpl(clazz, f, lf);
+      if (rarely()) {
+        fsdir = new FileSwitchDirectory(Set.of("fdt", "fdx", "tim"), fsdir, newFSDirectoryImpl(clazz, f, lf), true);
 
 Review comment:
   We could maybe randomize which extensions we add to the set here for better testing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org