You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Anita Jebaraj <aj...@us.ibm.com> on 2017/05/30 20:10:02 UTC
Review Request 59649: Delete view privileges from the Users page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59649/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
Bugs: AMBARI-21130
https://issues.apache.org/jira/browse/AMBARI-21130
Repository: ambari
Description
-------
The view permissions are listed in the users page, but in order to remove it, the user has to drill down to the views page and remove the user from it. To remove the permission for multiple views for one users, we have to navigate to different Views page to perform the operation
Including a delete option in the Users page for views privilege will simply this
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js 0706620
ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 7abdf05
Diff: https://reviews.apache.org/r/59649/diff/1/
Testing
-------
Ran mvn test
File Attachments
----------------
Image1.PNG
https://reviews.apache.org/media/uploaded/files/2017/05/30/9a10ff48-75ed-491f-95ac-5125acab6283__Image1.PNG
Thanks,
Anita Jebaraj
Re: Review Request 59649: Delete view privileges from the Users page
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59649/#review176628
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On May 30, 2017, 8:10 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59649/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 8:10 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-21130
> https://issues.apache.org/jira/browse/AMBARI-21130
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The view permissions are listed in the users page, but in order to remove it, the user has to drill down to the views page and remove the user from it. To remove the permission for multiple views for one users, we have to navigate to different Views page to perform the operation
>
> Including a delete option in the Users page for views privilege will simply this
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js 0706620
> ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 7abdf05
>
>
> Diff: https://reviews.apache.org/r/59649/diff/1/
>
>
> Testing
> -------
>
> Ran mvn test
>
>
> File Attachments
> ----------------
>
> Image1.PNG
> https://reviews.apache.org/media/uploaded/files/2017/05/30/9a10ff48-75ed-491f-95ac-5125acab6283__Image1.PNG
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 59649: Delete view privileges from the Users page
Posted by Di Li <di...@ca.ibm.com>.
> On June 1, 2017, 5:39 p.m., Di Li wrote:
> > Ship It!
>
> Anita Jebaraj wrote:
> Can you please help in pushing the changes?
done, you can close this request now
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59649/#review176633
-----------------------------------------------------------
On May 30, 2017, 8:10 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59649/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 8:10 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-21130
> https://issues.apache.org/jira/browse/AMBARI-21130
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The view permissions are listed in the users page, but in order to remove it, the user has to drill down to the views page and remove the user from it. To remove the permission for multiple views for one users, we have to navigate to different Views page to perform the operation
>
> Including a delete option in the Users page for views privilege will simply this
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js 0706620
> ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 7abdf05
>
>
> Diff: https://reviews.apache.org/r/59649/diff/1/
>
>
> Testing
> -------
>
> Ran mvn test
>
>
> File Attachments
> ----------------
>
> Image1.PNG
> https://reviews.apache.org/media/uploaded/files/2017/05/30/9a10ff48-75ed-491f-95ac-5125acab6283__Image1.PNG
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 59649: Delete view privileges from the Users page
Posted by Anita Jebaraj <aj...@us.ibm.com>.
> On June 1, 2017, 5:39 p.m., Di Li wrote:
> > Ship It!
Can you please help in pushing the changes?
- Anita
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59649/#review176633
-----------------------------------------------------------
On May 30, 2017, 8:10 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59649/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 8:10 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-21130
> https://issues.apache.org/jira/browse/AMBARI-21130
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The view permissions are listed in the users page, but in order to remove it, the user has to drill down to the views page and remove the user from it. To remove the permission for multiple views for one users, we have to navigate to different Views page to perform the operation
>
> Including a delete option in the Users page for views privilege will simply this
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js 0706620
> ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 7abdf05
>
>
> Diff: https://reviews.apache.org/r/59649/diff/1/
>
>
> Testing
> -------
>
> Ran mvn test
>
>
> File Attachments
> ----------------
>
> Image1.PNG
> https://reviews.apache.org/media/uploaded/files/2017/05/30/9a10ff48-75ed-491f-95ac-5125acab6283__Image1.PNG
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 59649: Delete view privileges from the Users page
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59649/#review176633
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On May 30, 2017, 8:10 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59649/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 8:10 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-21130
> https://issues.apache.org/jira/browse/AMBARI-21130
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The view permissions are listed in the users page, but in order to remove it, the user has to drill down to the views page and remove the user from it. To remove the permission for multiple views for one users, we have to navigate to different Views page to perform the operation
>
> Including a delete option in the Users page for views privilege will simply this
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js 0706620
> ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 7abdf05
>
>
> Diff: https://reviews.apache.org/r/59649/diff/1/
>
>
> Testing
> -------
>
> Ran mvn test
>
>
> File Attachments
> ----------------
>
> Image1.PNG
> https://reviews.apache.org/media/uploaded/files/2017/05/30/9a10ff48-75ed-491f-95ac-5125acab6283__Image1.PNG
>
>
> Thanks,
>
> Anita Jebaraj
>
>