You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by henryr <gi...@git.apache.org> on 2017/11/03 00:08:33 UTC

[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

GitHub user henryr opened a pull request:

    https://github.com/apache/spark/pull/19647

    [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

    ## What changes were proposed in this pull request?
    
    It's not safe in all cases to push down a LIMIT below a FULL OUTER
    JOIN. If the limit is pushed to one side of the FOJ, the physical
    join operator can not tell if a row in the non-limited side would have a
    match in the other side.
    
    *If* the join operator guarantees that unmatched tuples from the limited
    side are emitted before any unmatched tuples from the other side,
    pushing down the limit is safe. But this is impractical for some join
    implementations, e.g. SortMergeJoin.
    
    For now, disable limit pushdown through a FULL OUTER JOIN, and we can
    evaluate whether a more complicated solution is necessary in the future.
    
    ## How was this patch tested?
    
    Ran org.apache.spark.sql.* tests. Altered full outer join tests in
    LimitPushdownSuite.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/henryr/spark spark-22211

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19647
    
----
commit 0e0123b0887aa33c382a63ee7843be5f64d38b41
Author: Henry Robinson <he...@cloudera.com>
Date:   2017-10-30T22:48:33Z

    [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown
    
    ## What changes were proposed in this pull request?
    
    It's not safe in all cases to push down a LIMIT below a FULL OUTER
    JOIN. If the limit is pushed to one side of the FOJ, the physical
    join operator can not tell if a row in the non-limited side would have a
    match in the other side.
    
    *If* the join operator guarantees that unmatched tuples from the limited
    side are emitted before any unmatched tuples from the other side,
    pushing down the limit is safe. But this is impractical for some join
    implementations, e.g. SortMergeJoin.
    
    For now, disable limit pushdown through a FULL OUTER JOIN, and we can
    evaluate whether a more complicated solution is necessary in the future.
    
    ## How was this patch tested?
    
    Ran org.apache.spark.sql.* tests. Altered full outer join tests in
    LimitPushdownSuite.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

Posted by henryr <gi...@git.apache.org>.
Github user henryr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19647#discussion_r149844767
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala ---
    @@ -113,35 +113,34 @@ class LimitPushdownSuite extends PlanTest {
     
       test("full outer join where neither side is limited and both sides have same statistics") {
    --- End diff --
    
    See https://github.com/apache/spark/pull/19701. I think something got dropped in the backport to branch-2.2, so thankfully it's an easy fix.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83454/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

Posted by henryr <gi...@git.apache.org>.
Github user henryr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19647#discussion_r149842522
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala ---
    @@ -113,35 +113,34 @@ class LimitPushdownSuite extends PlanTest {
     
       test("full outer join where neither side is limited and both sides have same statistics") {
    --- End diff --
    
    Sure, I'm taking a look now.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19647#discussion_r149842748
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala ---
    @@ -113,35 +113,34 @@ class LimitPushdownSuite extends PlanTest {
     
       test("full outer join where neither side is limited and both sides have same statistics") {
    --- End diff --
    
    Thank you, all!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83432/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83367/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19647#discussion_r148710991
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -332,32 +332,18 @@ object LimitPushDown extends Rule[LogicalPlan] {
         // pushdown Limit.
         case LocalLimit(exp, Union(children)) =>
           LocalLimit(exp, Union(children.map(maybePushLocalLimit(exp, _))))
    -    // Add extra limits below OUTER JOIN. For LEFT OUTER and FULL OUTER JOIN we push limits to the
    -    // left and right sides, respectively. For FULL OUTER JOIN, we can only push limits to one side
    -    // because we need to ensure that rows from the limited side still have an opportunity to match
    -    // against all candidates from the non-limited side. We also need to ensure that this limit
    -    // pushdown rule will not eventually introduce limits on both sides if it is applied multiple
    -    // times. Therefore:
    +    // Add extra limits below OUTER JOIN. For LEFT OUTER and RIGHT OUTER JOIN we push limits to
    +    // the left and right sides, respectively. It's not safe to push limits below FULL OUTER
    +    // JOIN in the general case without a more invasive rewrite.
    +    // We also need to ensure that this limit pushdown rule will not eventually introduce limits
    +    // on both sides if it is applied multiple times. Therefore:
         //   - If one side is already limited, stack another limit on top if the new limit is smaller.
         //     The redundant limit will be collapsed by the CombineLimits rule.
         //   - If neither side is limited, limit the side that is estimated to be bigger.
         case LocalLimit(exp, join @ Join(left, right, joinType, _)) =>
           val newJoin = joinType match {
             case RightOuter => join.copy(right = maybePushLocalLimit(exp, right))
             case LeftOuter => join.copy(left = maybePushLocalLimit(exp, left))
    -        case FullOuter =>
    --- End diff --
    
    Thanks for working on it! We should still keep it. 
    
    Let me fix it based on my original PR: https://github.com/apache/spark/pull/10454


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    retest this please



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by henryr <gi...@git.apache.org>.
Github user henryr commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    **[Test build #83417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83417/testReport)** for PR 19647 at commit [`0e0123b`](https://github.com/apache/spark/commit/0e0123b0887aa33c382a63ee7843be5f64d38b41).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19647


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    **[Test build #83454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83454/testReport)** for PR 19647 at commit [`0e0123b`](https://github.com/apache/spark/commit/0e0123b0887aa33c382a63ee7843be5f64d38b41).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    **[Test build #83432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83432/testReport)** for PR 19647 at commit [`0e0123b`](https://github.com/apache/spark/commit/0e0123b0887aa33c382a63ee7843be5f64d38b41).
     * This patch **fails due to an unknown error code, -9**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19647#discussion_r148832366
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -332,32 +332,18 @@ object LimitPushDown extends Rule[LogicalPlan] {
         // pushdown Limit.
         case LocalLimit(exp, Union(children)) =>
           LocalLimit(exp, Union(children.map(maybePushLocalLimit(exp, _))))
    -    // Add extra limits below OUTER JOIN. For LEFT OUTER and FULL OUTER JOIN we push limits to the
    -    // left and right sides, respectively. For FULL OUTER JOIN, we can only push limits to one side
    -    // because we need to ensure that rows from the limited side still have an opportunity to match
    -    // against all candidates from the non-limited side. We also need to ensure that this limit
    -    // pushdown rule will not eventually introduce limits on both sides if it is applied multiple
    -    // times. Therefore:
    +    // Add extra limits below OUTER JOIN. For LEFT OUTER and RIGHT OUTER JOIN we push limits to
    +    // the left and right sides, respectively. It's not safe to push limits below FULL OUTER
    +    // JOIN in the general case without a more invasive rewrite.
    +    // We also need to ensure that this limit pushdown rule will not eventually introduce limits
    +    // on both sides if it is applied multiple times. Therefore:
         //   - If one side is already limited, stack another limit on top if the new limit is smaller.
         //     The redundant limit will be collapsed by the CombineLimits rule.
         //   - If neither side is limited, limit the side that is estimated to be bigger.
         case LocalLimit(exp, join @ Join(left, right, joinType, _)) =>
           val newJoin = joinType match {
             case RightOuter => join.copy(right = maybePushLocalLimit(exp, right))
             case LeftOuter => join.copy(left = maybePushLocalLimit(exp, left))
    -        case FullOuter =>
    --- End diff --
    
    We decide to disable it and merge it to master and the previous release 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83414/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19647#discussion_r149841578
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala ---
    @@ -113,35 +113,34 @@ class LimitPushdownSuite extends PlanTest {
     
       test("full outer join where neither side is limited and both sides have same statistics") {
    --- End diff --
    
    Hi, @gatorsmile and @henryr .
    This breaks `branch-2.2`.
    ```
    [info] - full outer join where neither side is limited and both sides have same statistics *** FAILED *** (43 milliseconds)
    [info] - full outer join where neither side is limited and left side has larger statistics *** FAILED *** (12 milliseconds)
    [info] - full outer join where neither side is limited and right side has larger statistics *** FAILED *** (9 milliseconds)
    ```
    cc @felixcheung for 2.2.1.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83430/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    **[Test build #83432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83432/testReport)** for PR 19647 at commit [`0e0123b`](https://github.com/apache/spark/commit/0e0123b0887aa33c382a63ee7843be5f64d38b41).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19647#discussion_r149841853
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala ---
    @@ -113,35 +113,34 @@ class LimitPushdownSuite extends PlanTest {
     
       test("full outer join where neither side is limited and both sides have same statistics") {
    --- End diff --
    
    Could you submit a fix to resolve the test failure?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    test this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    **[Test build #83454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83454/testReport)** for PR 19647 at commit [`0e0123b`](https://github.com/apache/spark/commit/0e0123b0887aa33c382a63ee7843be5f64d38b41).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19647
  
    Thanks! Merged to master/2.2


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org