[GitHub] [qpid-proton] jdanekrh commented on a change in pull request #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

[GitBox <gi...@apache.org>]

jdanekrh commented on a change in pull request #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr
URL: https://github.com/apache/qpid-proton/pull/176#discussion_r306354635
 
 

 ##########
 File path: c/src/platform/platform.h
 ##########
 @@ -65,7 +65,7 @@ int pn_i_error_from_errno(pn_error_t *error, const char *msg);
  */
 int64_t pn_i_atoll(const char* num);
 
-int pni_snprintf(char *buf, size_t count, const char *fmt, ...);
+PN_EXTERN int pni_snprintf(char *buf, size_t count, const char *fmt, ...);
 
 Review comment:
   I saw two `pni_` symbols in qpid-proton-cored.lib already, so I did it this way. Ok, I'll link it directly.
   
       dumpbin /EXPORTS qpid-proton\out\build\x64-Debug\c\qpid-proton-cored.lib
   
       [...]
   
                     pn_void_refcount
                     pn_work_head
                     pn_work_next
                     pni_message_get_extra
                     pni_message_with_extra
                     pnx_sasl_clear_password
                     pnx_sasl_error
                     pnx_sasl_fail_authentication
                     pnx_sasl_get_allow_insecure_mechs
                     pnx_sasl_get_auth_required
                     pnx_sasl_get_context
                     pnx_sasl_get_external_ssf
       [...]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org