[GitHub] [spark] shivsood commented on a change in pull request #24969: [SPARK-28151] ByteType, ShortType and FloatTypes are not correctly mapped for read/write of SQLServer tables

[GitBox <gi...@apache.org>]

shivsood commented on a change in pull request #24969: [SPARK-28151] ByteType, ShortType and FloatTypes are not correctly mapped for read/write of SQLServer tables
URL: https://github.com/apache/spark/pull/24969#discussion_r298921494
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala
 ##########
 @@ -30,7 +30,13 @@ private object MsSqlServerDialect extends JdbcDialect {
       // String is recommend by Microsoft SQL Server for datetimeoffset types in non-MS clients
       Option(StringType)
     } else {
-      None
+      val answer = sqlType match {
 
 Review comment:
   Thanks. Will make a fix. Change to Some(x) will avoid the null check which is redundant in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org