[GitHub] [incubator-superset] suddjian commented on a change in pull request #9098: SIP-32: Moving frontend code to the base of the repo

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #9098: SIP-32: Moving frontend code to the base of the repo
URL: https://github.com/apache/incubator-superset/pull/9098#discussion_r376520288
 
 

 ##########
 File path: superset-frontend/package.json
 ##########
 @@ -13,7 +13,7 @@
     "cover": "jest --coverage",
     "dev": "webpack --mode=development --colors --progress --debug --watch",
     "dev-server": "node --max_old_space_size=4096 ./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode=development --progress",
-    "prod": "node --max_old_space_size=4096 webpack --mode=production --colors --progress",
+    "prod": "node --max_old_space_size=4096 ./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode=production --colors --progress",
 
 Review comment:
   oops good catch. Copy/paste oversight there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org