You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/12 14:16:50 UTC

[GitHub] [spark] srielau commented on a diff in pull request #37834: [SPARK-40400][SQL] Pass error message parameters to exceptions as maps

srielau commented on code in PR #37834:
URL: https://github.com/apache/spark/pull/37834#discussion_r968478113


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -490,7 +490,7 @@
   },
   "UNRESOLVED_MAP_KEY" : {
     "message" : [
-      "Cannot resolve column <columnName> as a map key. If the key is a string literal, please add single quotes around it."
+      "Cannot resolve column <objectName> as a map key. If the key is a string literal, please add single quotes around it."

Review Comment:
   Note: we will not get away with renaming parameter names in the long run, once third parties start building dependencies on the API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org