You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/10/12 17:48:54 UTC

[GitHub] spark pull request #22383: [SPARK-25362][JavaAPI] Replace Spark Optional cla...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22383#discussion_r224866566
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -36,6 +36,8 @@ object MimaExcludes {
     
       // Exclude rules for 3.0.x
       lazy val v30excludes = v24excludes ++ Seq(
    +    // [SPARK-25362][JavaAPI] Replace Spark Optional class with Java Optional
    +    ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.api.java.Optional")
    --- End diff --
    
    Sorry @mmolimar this needs a rebase; another change just added a line here and it conflicts. Otherwise looking good


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org