[GitHub] [incubator-inlong] healchow commented on a change in pull request #3217: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id

[GitBox <gi...@apache.org>]

healchow commented on a change in pull request #3217:
URL: https://github.com/apache/incubator-inlong/pull/3217#discussion_r829695528



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;

Review comment:
       It is recommended to modify it to `nameList`.

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;
+
+    @ApiModelProperty(value = "Inlong group id list")
+    private List<String> inlongGroupIds;

Review comment:
       It is recommended to modify it to `groupIdList`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org