You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/08/17 11:31:26 UTC
Review Request 72781: Updated volume manager to support user specified
target path root.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72781/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10150
https://issues.apache.org/jira/browse/MESOS-10150
Repository: mesos
Description
-------
Updated volume manager to support user specified target path root.
Diffs
-----
src/csi/v0_volume_manager.cpp 9e840a762d9785ce48e011354dbb10295d9c6b38
src/csi/v0_volume_manager_process.hpp 11629559dff7f17eee489ff3e0e4b9566ff50d59
src/csi/v1_volume_manager.cpp 7230676c2d1ba0cafce9bc6e45c00ece7fb09f0c
src/csi/v1_volume_manager_process.hpp 63dc03ee52923d2639c9f8253e84924a8c8897b4
src/slave/csi_server.cpp a9a399579c6f7683b36e72582da20ea39311a222
Diff: https://reviews.apache.org/r/72781/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72781: Updated volume manager to support user
specified target path root.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72781/#review221600
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72781]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Aug. 17, 2020, 11:31 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72781/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2020, 11:31 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10150
> https://issues.apache.org/jira/browse/MESOS-10150
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated volume manager to support user specified target path root.
>
>
> Diffs
> -----
>
> src/csi/v0_volume_manager.cpp 9e840a762d9785ce48e011354dbb10295d9c6b38
> src/csi/v0_volume_manager_process.hpp 11629559dff7f17eee489ff3e0e4b9566ff50d59
> src/csi/v1_volume_manager.cpp 7230676c2d1ba0cafce9bc6e45c00ece7fb09f0c
> src/csi/v1_volume_manager_process.hpp 63dc03ee52923d2639c9f8253e84924a8c8897b4
> src/slave/csi_server.cpp a9a399579c6f7683b36e72582da20ea39311a222
>
>
> Diff: https://reviews.apache.org/r/72781/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72781: Updated volume manager to support user
specified target path root.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72781/#review221610
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Aug. 17, 2020, 11:31 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72781/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2020, 11:31 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10150
> https://issues.apache.org/jira/browse/MESOS-10150
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated volume manager to support user specified target path root.
>
>
> Diffs
> -----
>
> src/csi/v0_volume_manager.cpp 9e840a762d9785ce48e011354dbb10295d9c6b38
> src/csi/v0_volume_manager_process.hpp 11629559dff7f17eee489ff3e0e4b9566ff50d59
> src/csi/v1_volume_manager.cpp 7230676c2d1ba0cafce9bc6e45c00ece7fb09f0c
> src/csi/v1_volume_manager_process.hpp 63dc03ee52923d2639c9f8253e84924a8c8897b4
> src/slave/csi_server.cpp a9a399579c6f7683b36e72582da20ea39311a222
>
>
> Diff: https://reviews.apache.org/r/72781/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>