You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/27 04:59:09 UTC
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10283: [Enhancement][Vectorized] add constexpr_loop_match
BiteTheDDDDt commented on code in PR #10283:
URL: https://github.com/apache/doris/pull/10283#discussion_r906973309
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -509,11 +517,6 @@ struct ProcessHashTableProbe {
}
output_block->get_by_position(result_column_id).column =
std::move(new_filter_column);
- } else if constexpr (JoinOpType::value == TJoinOp::RIGHT_OUTER_JOIN) {
Review Comment:
> why delete this code?
`RIGHT_OUTER_JOIN` is toe to toe with `RIGHT_SEMI_JOIN/RIGHT_ANTI_JOIN` now.
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -509,11 +517,6 @@ struct ProcessHashTableProbe {
}
output_block->get_by_position(result_column_id).column =
std::move(new_filter_column);
- } else if constexpr (JoinOpType::value == TJoinOp::RIGHT_OUTER_JOIN) {
Review Comment:
> why delete this code?
`RIGHT_OUTER_JOIN` is toe to toe with `RIGHT_SEMI_JOIN/RIGHT_ANTI_JOIN` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org