[jira] [Commented] (MAPREDUCE-3485) DISKS_FAILED -101 error code should be defined in same location as ABORTED_CONTAINER_EXIT_STATUS

["Hitesh Shah (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160711#comment-13160711 ] 

Hitesh Shah commented on MAPREDUCE-3485:
----------------------------------------

Change looks fine except for one minor nit. @Ravi, could you add some documentation for the error value.
                
> DISKS_FAILED -101 error code should be defined in same location as ABORTED_CONTAINER_EXIT_STATUS
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3485
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3485
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Hitesh Shah
>            Assignee: Ravi Gummadi
>             Fix For: 0.23.1
>
>         Attachments: 3485.patch
>
>
> With MAPREDUCE-3121, it is defined in ContainerExecutor as part of yarn-nodemanager which would be a problem for client-side code if it needs to understand the exit code. 
> A short term fix would be to move it into YarnConfiguration where ABORTED_CONTAINER_EXIT_STATUS is defined. A longer term fix would be to find a more formal and extensible approach for new yarn framework error codes to be added and be easily accessible to client-side code or other AMs. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira