[GitHub] [helix] junkaixue commented on a change in pull request #1792: Fix MaintenanceRecoveryStage Hanging

[GitBox <gi...@apache.org>]

junkaixue commented on a change in pull request #1792:
URL: https://github.com/apache/helix/pull/1792#discussion_r649569918



##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -513,13 +513,13 @@ private static PipelineRegistry createDefaultRegistry(String pipelineName) {
       rebalancePipeline.addStage(new BestPossibleStateCalcStage());
       // Need to add MaintenanceRecoveryStage here because MAX_PARTITIONS_PER_INSTANCE check could
       // only occur after IntermediateStateCalcStage calculation
-      rebalancePipeline.addStage(new MaintenanceRecoveryStage());
       rebalancePipeline.addStage(new MessageGenerationPhase());
       rebalancePipeline.addStage(new MessageSelectionStage());
       // The IntermediateStateCalcStage should be applied after message selection
       // Messages are throttled already removed by IntermediateStateCalcStage in MessageSelection output
       rebalancePipeline.addStage(new IntermediateStateCalcStage());
       rebalancePipeline.addStage(new MessageThrottleStage());
+      rebalancePipeline.addStage(new MaintenanceRecoveryStage());

Review comment:
       Because they are correlated. For phase2, we would like to combine IntermediateStage and MessageThrottling together. Thus the result can impact the decision of MaintenanceRecovery As well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org