[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

[GitBox <gi...@apache.org>]

runitao commented on a change in pull request #1289:
URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467179243



##########
File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto
##########
@@ -43,14 +43,22 @@ message DatanodeDetailsProto {
     // network name, can be Ip address or host name, depends
     optional string networkName = 6;
     optional string networkLocation = 7; // Network topology location
-    optional string version = 8;         // Datanode version

Review comment:
       @avijayanhwx  Thanks for review. No problem. But I need to confirm. 
   Should I only keep version and setupTime(these two fields added in 0.6.0) or keep these four fields?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org