[jira] [Commented] (NET-554) Simplify TelnetOptionHandler class hierarchy

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NET-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228592#comment-14228592 ] 

Sebb commented on NET-554:
--------------------------

This would require changing the parent class implementation to remove the abstract modifier.

According to:

https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.16

removal of the abstract modifier does not break binary compatibility (but adding it would).


> Simplify TelnetOptionHandler class hierarchy
> --------------------------------------------
>
>                 Key: NET-554
>                 URL: https://issues.apache.org/jira/browse/NET-554
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: Telnet
>            Reporter: Sebb
>            Priority: Minor
>
> The TelnetOptionHandler class contains the following abstract methods:
> answerSubnegotiation
> startSubnegotiationLocal
> startSubnegotiationRemote
> In almost all the sub-classes, the implementation returns null.
> The code could be simplified by returning null in the parent class and dropping the sub-class implementations that just return null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)