[jira] Resolved: (JENA-38) FileOps.delete() contains a System.exit() call

["Andy Seaborne (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JENA-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Seaborne resolved JENA-38.
-------------------------------

    Resolution: Fixed

Fixed in SF codebase.
Now issues warnings on security exceptions and does nothing special on other exceptions.

> FileOps.delete() contains a System.exit() call
> ----------------------------------------------
>
>                 Key: JENA-38
>                 URL: https://issues.apache.org/jira/browse/JENA-38
>             Project: Jena
>          Issue Type: Bug
>          Components: ARQ
>            Reporter: Stephen Allen
>            Priority: Minor
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The org.openjena.atlas.lib.FileOps.delete(File f, boolean reportExistsAfter) [1] method contains a System.exit(1) call if an exception occurs while deleting a file.  Javadoc says that File.delete() can throw a SecurityException.  It is dangerous to have System.exit() calls in library code.
> The fix should probably just be to remove the try/catch block.  Currently there doesn't appear to be any code that calls this method.
> [1] ARQ/trunk/src/org/openjena/atlas/lib/FileOps.java: line 45

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira