You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/07/12 07:57:44 UTC
[GitHub] [cordova-electron] RaddishIoW opened a new issue, #240: Unable to pass Publish options to electron-builder
RaddishIoW opened a new issue, #240:
URL: https://github.com/apache/cordova-electron/issues/240
# Bug Report
## Problem
### What is expected to happen?
I am able to pass configuration to electron-builder to define Publish parameters.
### What does actually happen?
I am unable to pass parameters correctly through to electron-builder. It seems that the way cordova-electron intermediates between the developer and electron-builder is unnecessarily complex and leads to errors and problems with the ability to configure electron-builder.
According to the documentation for electron-builder, you should be able to pass through "publish" options as a top-level object, or per platform or per target: https://www.electron.build/configuration/publish
## Information
<!-- Include all relevant information that might help understand and reproduce the problem -->
According to the documentation for cordova-electron, the only valid keys for the "electron" config object in the `build.json` file are "mac", "windows" and "linux". Anything else is ignored and not passed through to electron-builder in the `builder-effective-config.yaml` file.
### Command or Code
<!-- What command or code is needed to reproduce the problem? -->
### Environment, Platform, Device
<!-- In what environment, on what platform or on which device are you experiencing the issue? -->
### Version information
<!--
What are relevant versions you are using?
For example:
Cordova: Cordova CLI, Cordova Platforms, Cordova Plugins
Other Frameworks: Ionic Framework and CLI version
Operating System, Android Studio, Xcode etc.
-->
## Checklist
<!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
- [x ] I searched for existing GitHub issues
- [ x] I updated all Cordova tooling to most recent version
- [ x] I included all the necessary information above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] RaddishIoW commented on issue #240: Unable to pass Publish options to electron-builder
Posted by GitBox <gi...@apache.org>.
RaddishIoW commented on issue #240:
URL: https://github.com/apache/cordova-electron/issues/240#issuecomment-1285316286
Hmm... So I've been digging around a little in the code to get prepared for this, and it seems to me that this should already be possible, as there is code for handling overridable per-platform config options - however, there is a function called `__validateUserPlatformBuildSettings` which gets called and throws an error if there are any extra keys in the config which aren't `platformConfigs.package || platformConfigs.arch || platformConfigs.signing`.
I can't see why this is there? The code supports other keys in the config, and there is even a test in `tests/spec/unit/lib/build.spec.js` which tests that this works! IRL, the build never gets to this point with any of the overridable keys in the platform configs as it's stopped by the `__validateUserPlatformBuildSettings` function call first.
Can anyone shed any light on this? This code comes from PR #4 waaaay back...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] RaddishIoW commented on issue #240: Unable to pass Publish options to electron-builder
Posted by GitBox <gi...@apache.org>.
RaddishIoW commented on issue #240:
URL: https://github.com/apache/cordova-electron/issues/240#issuecomment-1285243273
I would like to work on this issue to enable publishing options to be passed to `electron-builder`.
Specifically, I would like to be able to pass options through to enable auto-updating of Electron apps using the built-in publish options of `electron-builder`.
I will create a fork and start work, if this could be assigned to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org