[jira] [Commented] (FLINK-10843) Make Kafka version definition more flexible for new Kafka table factory

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685165#comment-16685165 ] 

ASF GitHub Bot commented on FLINK-10843:
----------------------------------------

twalthr opened a new pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible
URL: https://github.com/apache/flink/pull/7087
 
 
   ## What is the purpose of the change
   
   This PR makes the versioning of a Kafka table factory more flexible. It still forces a Kafka version for future backwards compatibility cases. It allows for `1.*` and `2.*` versioning for the modern Kafka connector. However, a user can always fallback to a `universal` version wildcard.
   
   
   ## Brief change log
   
   - Extended Kafka validator 
   - Extended Kafka table factory
   
   ## Verifying this change
   
   Existing tests are still correct.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make Kafka version definition more flexible for new Kafka table factory
> -----------------------------------------------------------------------
>
>                 Key: FLINK-10843
>                 URL: https://issues.apache.org/jira/browse/FLINK-10843
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector, Table API & SQL
>    Affects Versions: 1.7.0
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, a user has to specify a specific version for a Kafka connector like:
> {code}
> connector:
>   type: kafka
>   version: "0.11"     # required: valid connector versions are "0.8", "0.9", "0.10", and "0.11"
>   topic: ...          # required: topic name from which the table is read
> {code}
> However, the new Kafka connector aims to be universal, thus, at least for 1.x and 2.x versions which we should support those as parameters as well. Currently, {{2.0}} is the only accepted string for the factory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)