You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Paul McMahan (JIRA)" <ji...@apache.org> on 2007/01/23 07:32:49 UTC
[jira] Created: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Enabling web statistics collection for jetty fails from the admin console
-------------------------------------------------------------------------
Key: GERONIMO-2775
URL: https://issues.apache.org/jira/browse/GERONIMO-2775
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: console, Jetty
Affects Versions: 2.0-M2
Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
Reporter: Paul McMahan
in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2775) Enabling web statistics
collection for jetty fails from the admin console
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531795 ]
Joe Bohn commented on GERONIMO-2775:
------------------------------------
Viet, Thanks for the new patch. Things still aren't right with Jetty. The late binding is better since we're not running stats from the start. However, it still appears that we don't really disable the stats when "stop" is invoked on the StatisticsHandler. I think we need ask on the Jetty list the proper way that the StatisticsHandler is supposed to behave since there appear to be some bugs.
On the patch itself here are a few suggestions:
- It may not be necessary to iterate thru the handlers looking for the statisticsHandler prior to adding it. Also, it really doesn't seem necessary to iterate thru all of the handlers on each request to enable or disable collection of statistics. Since this is the only area of the code that would set the handler something simple like this should be all that is necessary:
{noformat}
if (on) {
// set the statistics handler if not already done so
if (!statsHandlerInPlace) {
handlerCollection.addHandler(statsHandler);
statsHandlerInPlace = true;
}
...
{noformat}
Also, the calculating of the starttime seems inefficient and will produce slightly different results on each stat. Perhaps we should calculate the start time once and apply it to all fields or maybe better just add the start time in setCollectStatistics() using the current GMT rather than calculating at all. Also, the last sample time isn't quite correct since we really don't know when the last sample actually was taken .... I suppose a guess based on the current time is better than nothing but I wonder if there is something better.
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0.x
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Assignee: Joe Bohn
> Attachments: geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-2775:
---------------------------------------
Attachment: geronimo-2775.patch
I have gotten rid of the extra things. Here is the updated patch.
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0-M2
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Attachments: geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-2775:
---------------------------------------
Attachment: geronimo-2775.patch
provides correct startTime and lastSampleTime. Also, container stats are off by default.
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0.x
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Assignee: Joe Bohn
> Attachments: geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bohn reassigned GERONIMO-2775:
----------------------------------
Assignee: Joe Bohn
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0.x
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Assignee: Joe Bohn
> Attachments: geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-2775:
---------------------------------------
Attachment: geronimo-2775.patch
I have made the 'enable' link to attempt to show the stats. But the statistics are currently being worked on, so what is shown does not mean anything.
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0-M2
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Attachments: geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bohn updated GERONIMO-2775:
-------------------------------
Affects Version/s: (was: 2.0.x)
2.0.1
Fix Version/s: (was: 2.0.x)
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0.1
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Assignee: Joe Bohn
> Fix For: 2.0.2, 2.1
>
> Attachments: geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2775) Enabling web statistics
collection for jetty fails from the admin console
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498055 ]
Anita Kulshreshtha commented on GERONIMO-2775:
----------------------------------------------
you should not need to add dependency on geronimo-tomcat6. Also keeping the patch free of white space editing is very helpful.
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0-M2
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Attachments: geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-2775:
---------------------------------------
Attachment: geronimo-2775.patch
I have surfaced the jetty6 container stats and updated the portlet to reflect the stats collection. However, the statistics that are provided by jetty5 are different from jetty6.
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0.x
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Attachments: geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2775) Enabling web statistics
collection for jetty fails from the admin console
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529272 ]
Joe Bohn commented on GERONIMO-2775:
------------------------------------
Thanks for providing the patch. It would be great to get the web stats working on Jetty again since we've moved to Jetty 6. However, there are two main concerns I have with this patch.
- The enable/disable capability is removed which means that the stats will always be running in jetty potentially impacting the system performance.
- More significant than that is the fact that this patch puts a hard dependency between console-standard and the geronimo-jetty6 module. There are classes from the jetty6 implementation directly included in the console. That means that when the console plugin is created it will have a dependency on geronimo-jetty and pull it along even in the tomcat installation. The console can do things to detect the web container and act appropriately but the console web app itself should not pull in jetty or tomcat elements directly.
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0.x
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Assignee: Joe Bohn
> Attachments: geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2775) Enabling web statistics
collection for jetty fails from the admin console
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498795 ]
Donald Woods commented on GERONIMO-2775:
----------------------------------------
Viet, your second patch only enables the get/set call and doesn't allow the stats to be displayed....
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0-M2
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Attachments: geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Posted by "Hernan Cunico (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hernan Cunico updated GERONIMO-2775:
------------------------------------
Affects Version/s: (was: 2.0-M2)
2.0.x
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0.x
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Attachments: geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-2775) Enabling web statistics collection
for jetty fails from the admin console
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bohn closed GERONIMO-2775.
------------------------------
Resolution: Fixed
Fix Version/s: 2.1
2.0.x
2.0.2
> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2775
> URL: https://issues.apache.org/jira/browse/GERONIMO-2775
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console, Jetty
> Affects Versions: 2.0.x
> Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
> Reporter: Paul McMahan
> Assignee: Joe Bohn
> Fix For: 2.0.2, 2.0.x, 2.1
>
> Attachments: geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch, geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" link for enabling statistics collection. The click is ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.