[jira] [Commented] (THRIFT-5375) Put org.apache.tomcat.embed:tomcat-embed-core into scope test

["Andy Seaborne (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306247#comment-17306247 ] 

Andy Seaborne commented on THRIFT-5375:
---------------------------------------

Noted added to [PR 1886|https://github.com/apache/thrift/pull/1866/files/9c9962b3e9f2410a922ed01b232dca2ceb5d4d29#r598767273] but I'm not a regular gradle user.

Context: Apache Jena uses thrift as its binary encoding of RDF data so it is only using that part of Thrift, which has worked well, thank you.

> Put org.apache.tomcat.embed:tomcat-embed-core into scope test
> -------------------------------------------------------------
>
>                 Key: THRIFT-5375
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5375
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.14.0, 0.14.1
>            Reporter: Andy Seaborne
>            Priority: Major
>
> 0.14.0 adds org.apache.tomcat.embed:tomcat-embed-core as a dependency with scope=compile. It becomes a dependency of systems using libthrift(java).
> It includes a tomcat-specific its own javax.servlet causing a conflict with javax.servlet:javax.servlet-api:jar:3.1.0 It gets included in combined jars that use Jetty.
> It causes tomcat-emdedded to be downstream systems that produce combined jars and docker images.
> The dependency was added by THRIFT-4949.
> The use of this seems to be specific to lib/java/test/org/apache/thrift/test/TestTServletServer.java and is not necessary at runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)