You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/05/07 00:11:32 UTC
Re: Review Request 20820: Updated tests to use a strict registry, by default.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20820/
-----------------------------------------------------------
(Updated May 6, 2014, 10:11 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebased, please take a look.
Bugs: MESOS-1317
https://issues.apache.org/jira/browse/MESOS-1317
Repository: mesos-git
Description
-------
This sets --registry_strict to true for all tests.
Diffs (updated)
-----
src/tests/fault_tolerance_tests.cpp 4796149beb10a6c668762f5efecd86520b809c42
src/tests/mesos.hpp 335b23ae5b0381be6dc6a321a35082db00345ff1
src/tests/mesos.cpp d1184e6a752bdd061c075def91bcfa2165ab10f2
Diff: https://reviews.apache.org/r/20820/diff/
Testing
-------
make check
1. I ended up fixing an unrelated gmock warning.
2. I discovered MESOS-1264, which is a flaky test and orthogonal to this change.
Everything else passes!
Thanks,
Ben Mahler
Re: Review Request 20820: Updated tests to use a strict registry, by default.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20820/
-----------------------------------------------------------
(Updated May 7, 2014, 1:05 a.m.)
Review request for Vinod Kone.
Changes
-------
Updated to reflect the slave authentication fixes.
Bugs: MESOS-1317
https://issues.apache.org/jira/browse/MESOS-1317
Repository: mesos-git
Description
-------
This sets --registry_strict to true for all tests.
Diffs
-----
src/tests/mesos.hpp 335b23ae5b0381be6dc6a321a35082db00345ff1
src/tests/mesos.cpp d1184e6a752bdd061c075def91bcfa2165ab10f2
Diff: https://reviews.apache.org/r/20820/diff/
Testing
-------
make check
1. I ended up fixing an unrelated gmock warning.
2. I discovered MESOS-1264, which is a flaky test and orthogonal to this change.
Everything else passes!
Thanks,
Ben Mahler
Re: Review Request 20820: Updated tests to use a strict registry, by default.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20820/
-----------------------------------------------------------
(Updated May 7, 2014, 12:55 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1317
https://issues.apache.org/jira/browse/MESOS-1317
Repository: mesos-git
Description
-------
This sets --registry_strict to true for all tests.
Diffs
-----
src/tests/mesos.hpp 335b23ae5b0381be6dc6a321a35082db00345ff1
src/tests/mesos.cpp d1184e6a752bdd061c075def91bcfa2165ab10f2
Diff: https://reviews.apache.org/r/20820/diff/
Testing
-------
make check
1. I ended up fixing an unrelated gmock warning.
2. I discovered MESOS-1264, which is a flaky test and orthogonal to this change.
Everything else passes!
Thanks,
Ben Mahler
Re: Review Request 20820: Updated tests to use a strict registry, by default.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20820/
-----------------------------------------------------------
(Updated May 7, 2014, 12:54 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Updated now that the slave authentication retry bug has been fixed.
Bugs: MESOS-1317
https://issues.apache.org/jira/browse/MESOS-1317
Repository: mesos-git
Description
-------
This sets --registry_strict to true for all tests.
Diffs (updated)
-----
src/tests/mesos.hpp 335b23ae5b0381be6dc6a321a35082db00345ff1
src/tests/mesos.cpp d1184e6a752bdd061c075def91bcfa2165ab10f2
Diff: https://reviews.apache.org/r/20820/diff/
Testing
-------
make check
1. I ended up fixing an unrelated gmock warning.
2. I discovered MESOS-1264, which is a flaky test and orthogonal to this change.
Everything else passes!
Thanks,
Ben Mahler