[GitHub] [beam] jrmccluskey commented on a diff in pull request #26882: [Go SDK][Prism] Prism fails pipelines that use features unimplemented in Prism.

["jrmccluskey (via GitHub)" <gi...@apache.org>]

jrmccluskey commented on code in PR #26882:
URL: https://github.com/apache/beam/pull/26882#discussion_r1210397840


##########
sdks/go/pkg/beam/runners/prism/internal/unimplemented_test.go:
##########
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package internal
+
+import (
+	"context"
+	"strings"
+	"testing"
+
+	"github.com/apache/beam/sdks/v2/go/pkg/beam"
+	"github.com/apache/beam/sdks/v2/go/pkg/beam/core/util/reflectx"
+	"github.com/apache/beam/sdks/v2/go/test/integration/primitives"
+)
+
+// This file covers pipelines with features that aren't yet supported by Prism.
+
+func intTestName(fn any) string {
+	name := reflectx.FunctionName(fn)
+	n := strings.LastIndex(name, "/")
+	return name[n+1:]
+}
+
+// TestUnimplemented validates that the kinds of pipelines that are expected
+// to fail due to unimplemented features, do.
+func TestUnimplemented(t *testing.T) {

Review Comment:
   Not a blocker by any means, but are there individual issues filed to implement different elements of these? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org