You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/04/14 00:41:06 UTC
Review Request 58443: Unit test for file/directory overwriting
support in provisioners.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Bugs: MESOS-5028
https://issues.apache.org/jira/browse/MESOS-5028
Repository: mesos
Description
-------
The test is based on the following image:
https://hub.docker.com/r/chhsiao/overwrite/
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp dbbc3533ae269c31c98017d98888d5748ef6e1ce
Diff: https://reviews.apache.org/r/58443/diff/1/
Testing
-------
sudo make check
This test is failed without patch 58408 but will be passed after the patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 58443: Unit test for file/directory overwriting
support in provisioners.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/#review171982
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58408, 58443]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 14, 2017, 12:41 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58443/
> -----------------------------------------------------------
>
> (Updated April 14, 2017, 12:41 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-5028
> https://issues.apache.org/jira/browse/MESOS-5028
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is based on the following image:
> https://hub.docker.com/r/chhsiao/overwrite/
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp dbbc3533ae269c31c98017d98888d5748ef6e1ce
>
>
> Diff: https://reviews.apache.org/r/58443/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> This test is failed without patch 58408 but will be passed after the patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 58443: Unit test for file/symlink/directory
overwriting in provisioners.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/#review172049
-----------------------------------------------------------
Bad review!
Reviews applied: [58443, 58463, 58408]
Error:
Circular dependency detected for review 58408.Please fix the 'depends_on' field.
- Mesos Reviewbot
On April 15, 2017, 8:46 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58443/
> -----------------------------------------------------------
>
> (Updated April 15, 2017, 8:46 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-5028 and MESOS-6327
> https://issues.apache.org/jira/browse/MESOS-5028
> https://issues.apache.org/jira/browse/MESOS-6327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is based on the following image:
> https://hub.docker.com/r/chhsiao/overwrite/
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
>
>
> Diff: https://reviews.apache.org/r/58443/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 58443: Unit test for file/symlink/directory
overwriting in provisioners.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/
-----------------------------------------------------------
(Updated April 18, 2017, 5:32 a.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Trying to resolve the weird cyclic dependency.
Bugs: MESOS-5028 and MESOS-6327
https://issues.apache.org/jira/browse/MESOS-5028
https://issues.apache.org/jira/browse/MESOS-6327
Repository: mesos
Description
-------
The test is based on the following image:
https://hub.docker.com/r/chhsiao/overwrite/
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
Diff: https://reviews.apache.org/r/58443/diff/3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 58443: Unit test for file/symlink/directory
overwriting in provisioners.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/
-----------------------------------------------------------
(Updated April 17, 2017, 11:06 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Updated comments.
Bugs: MESOS-5028 and MESOS-6327
https://issues.apache.org/jira/browse/MESOS-5028
https://issues.apache.org/jira/browse/MESOS-6327
Repository: mesos
Description
-------
The test is based on the following image:
https://hub.docker.com/r/chhsiao/overwrite/
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
Diff: https://reviews.apache.org/r/58443/diff/3/
Changes: https://reviews.apache.org/r/58443/diff/2-3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 58443: Unit test for file/symlink/directory
overwriting in provisioners.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On April 17, 2017, 2:25 a.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 729 (patched)
> > <https://reviews.apache.org/r/58443/diff/2/?file=1692899#file1692899line729>
> >
> > Not yours, but I think we should rename ProvisionerDockerPullerTest to ProvisionerDockerTest, and rename ProvisionerDockerWhiteoutTest to ProvisionerDockerBackendTest. We don't need this new test fixture. We should just re-use ProvisionerDockerBackendTest (which iterates all available backends).
> > ```
> > ProvisionerDockerBackendTest.XXX_Whiteout
> > ProvisionerDockerBackendTest.XXX_Overwrite
> > ```
> >
> > Let's pull the test renaming into a separate patch.
>
> Chun-Hung Hsiao wrote:
> So should I keep this PR is it is right now and make a new PR depending on this one?
Renaming done in https://reviews.apache.org/r/58488/.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/#review172065
-----------------------------------------------------------
On April 17, 2017, 11:06 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58443/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 11:06 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-5028 and MESOS-6327
> https://issues.apache.org/jira/browse/MESOS-5028
> https://issues.apache.org/jira/browse/MESOS-6327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is based on the following image:
> https://hub.docker.com/r/chhsiao/overwrite/
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
>
>
> Diff: https://reviews.apache.org/r/58443/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 58443: Unit test for file/symlink/directory
overwriting in provisioners.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On April 17, 2017, 2:25 a.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 729 (patched)
> > <https://reviews.apache.org/r/58443/diff/2/?file=1692899#file1692899line729>
> >
> > Not yours, but I think we should rename ProvisionerDockerPullerTest to ProvisionerDockerTest, and rename ProvisionerDockerWhiteoutTest to ProvisionerDockerBackendTest. We don't need this new test fixture. We should just re-use ProvisionerDockerBackendTest (which iterates all available backends).
> > ```
> > ProvisionerDockerBackendTest.XXX_Whiteout
> > ProvisionerDockerBackendTest.XXX_Overwrite
> > ```
> >
> > Let's pull the test renaming into a separate patch.
So should I keep this PR is it is right now and make a new PR depending on this one?
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/#review172065
-----------------------------------------------------------
On April 15, 2017, 12:46 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58443/
> -----------------------------------------------------------
>
> (Updated April 15, 2017, 12:46 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-5028 and MESOS-6327
> https://issues.apache.org/jira/browse/MESOS-5028
> https://issues.apache.org/jira/browse/MESOS-6327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is based on the following image:
> https://hub.docker.com/r/chhsiao/overwrite/
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
>
>
> Diff: https://reviews.apache.org/r/58443/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 58443: Unit test for file/symlink/directory
overwriting in provisioners.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/#review172065
-----------------------------------------------------------
src/tests/containerizer/provisioner_docker_tests.cpp
Lines 729 (patched)
<https://reviews.apache.org/r/58443/#comment245136>
Not yours, but I think we should rename ProvisionerDockerPullerTest to ProvisionerDockerTest, and rename ProvisionerDockerWhiteoutTest to ProvisionerDockerBackendTest. We don't need this new test fixture. We should just re-use ProvisionerDockerBackendTest (which iterates all available backends).
```
ProvisionerDockerBackendTest.XXX_Whiteout
ProvisionerDockerBackendTest.XXX_Overwrite
```
Let's pull the test renaming into a separate patch.
- Jie Yu
On April 15, 2017, 12:46 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58443/
> -----------------------------------------------------------
>
> (Updated April 15, 2017, 12:46 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-5028 and MESOS-6327
> https://issues.apache.org/jira/browse/MESOS-5028
> https://issues.apache.org/jira/browse/MESOS-6327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is based on the following image:
> https://hub.docker.com/r/chhsiao/overwrite/
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
>
>
> Diff: https://reviews.apache.org/r/58443/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 58443: Unit test for file/symlink/directory
overwriting in provisioners.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/
-----------------------------------------------------------
(Updated April 15, 2017, 12:46 a.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Added symlink overwriting test.
Summary (updated)
-----------------
Unit test for file/symlink/directory overwriting in provisioners.
Bugs: MESOS-5028 and MESOS-6327
https://issues.apache.org/jira/browse/MESOS-5028
https://issues.apache.org/jira/browse/MESOS-6327
Repository: mesos
Description
-------
The test is based on the following image:
https://hub.docker.com/r/chhsiao/overwrite/
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083
Diff: https://reviews.apache.org/r/58443/diff/2/
Changes: https://reviews.apache.org/r/58443/diff/1-2/
Testing (updated)
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 58443: Unit test for file/directory overwriting
support in provisioners.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58443/#review172037
-----------------------------------------------------------
Will update the test to include MESOS-6327
- Chun-Hung Hsiao
On April 14, 2017, 12:41 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58443/
> -----------------------------------------------------------
>
> (Updated April 14, 2017, 12:41 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-5028
> https://issues.apache.org/jira/browse/MESOS-5028
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is based on the following image:
> https://hub.docker.com/r/chhsiao/overwrite/
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp dbbc3533ae269c31c98017d98888d5748ef6e1ce
>
>
> Diff: https://reviews.apache.org/r/58443/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> This test is failed without patch 58408 but will be passed after the patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>