You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2019/06/01 17:45:15 UTC

[whimsy] branch master updated: Works OK if there is an LDAP group

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 1573022  Works OK if there is an LDAP group
1573022 is described below

commit 157302265c4c229e84a4f17ff7f64562ba619278
Author: Sebb <se...@apache.org>
AuthorDate: Sat Jun 1 18:45:11 2019 +0100

    Works OK if there is an LDAP group
---
 www/roster/views/nonpmc/members.js.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/roster/views/nonpmc/members.js.rb b/www/roster/views/nonpmc/members.js.rb
index 5c34f83..a5559d1 100644
--- a/www/roster/views/nonpmc/members.js.rb
+++ b/www/roster/views/nonpmc/members.js.rb
@@ -143,7 +143,6 @@ class NonPMCMember < Vue
         end
       elsif not @@person.date
         _td.issue.clickable 'not in committee-info.txt', onClick: self.select
-        # TODO the LDAP groups are not set up in the usual way so this is not all that useful at present
       elsif @@nonpmc.hasLDAP and not @@person.ldap
         _td.issue.clickable 'not in LDAP', onClick: self.select
       elsif @@nonpmc.hasLDAP and not @@nonpmc.committers.include? @@person.id